Remote assistance on Chrome OS Part IV - It2MeHost

remoting/host/chromeos/aura_desktop_capturer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/chromeos/aura_desktop_capturer.h"
 
 #include "ash/shell.h"
 #include "base/bind.h"
 #include "cc/output/copy_output_request.h"
 #include "cc/output/copy_output_result.h"
@@ skipping 22 matching lines @@
   scoped_ptr<SkBitmap> bitmap_;
 
   DISALLOW_COPY_AND_ASSIGN(SkiaBitmapDesktopFrame);
 };
 
 // static
 SkiaBitmapDesktopFrame* SkiaBitmapDesktopFrame::Create(
     scoped_ptr<SkBitmap> bitmap) {
 
   webrtc::DesktopSize size(bitmap->width(), bitmap->height());
-  DCHECK_EQ(kRGBA_8888_SkColorType, bitmap->info().colorType())

[rmsousa, 2014/10/14 00:18:25]

Out of curiosity: was this broken before? Are we the first feature to exercise
this code?

[kelvinp, 2014/10/15 23:03:09]

Yes, I created this file two weeks ago but it is not being exercised other than
unittest.  I create the DCHECK based on the comments on webrtc::DeskopFrame,
which is apparently incorrect.

-      << "DesktopFrame objects always hold RGBA data.";
+  DCHECK_EQ(kBGRA_8888_SkColorType, bitmap->info().colorType())
+      << "DesktopFrame objects always hold BGRA data.";

[Jamie, 2014/10/14 01:18:41]

There seem to be a couple of changes that flip the endianness, but there's
nothing in the CL description. If it's an unrelated bugfix, consider moving it
to another CL. If not, please mention it in the description.

[kelvinp, 2014/10/15 23:03:09]

This is required otherwise the DCHECK will fail after the remoting session is
connected. I will update the CL description.

 
   uint8_t* bitmap_data = reinterpret_cast<uint8_t*>(bitmap->getPixels());
 
   SkiaBitmapDesktopFrame* result = new SkiaBitmapDesktopFrame(
       size, bitmap->rowBytes(), bitmap_data, bitmap.Pass());
 
   return result;
 }
 
 SkiaBitmapDesktopFrame::SkiaBitmapDesktopFrame(webrtc::DesktopSize size,
@@ skipping 55 matching lines @@
       frame->size().width(), frame->size().height());
 
   // TODO(kelvinp): Set Frame DPI according to the screen resolution.
   // See cc::Layer::contents_scale_(x|y)() and frame->set_depi().
   frame->mutable_updated_region()->SetRect(rect);
 
   callback_->OnCaptureCompleted(frame.release());
 }
 
 }  // namespace remoting