net: Use SequencedTaskRunner for URLFetcherResponseWriter

chrome/browser/google_apis/base_requests.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/google_apis/base_requests.h"
 
 #include "base/json/json_reader.h"
 #include "base/location.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
@@ skipping 84 matching lines @@
                const std::string& json,
                const ParseJsonCallback& callback) {
   base::PostTaskAndReplyWithResult(
       blocking_task_runner,
       FROM_HERE,
       base::Bind(&ParseJsonOnBlockingPool, json),
       callback);
 }
 
 //=========================== ResponseWriter ==================================
-ResponseWriter::ResponseWriter(base::TaskRunner* file_task_runner,
+ResponseWriter::ResponseWriter(base::SequencedTaskRunner* file_task_runner,
                                const base::FilePath& file_path,
                                const GetContentCallback& get_content_callback)
     : get_content_callback_(get_content_callback) {
   if (!file_path.empty()) {
     file_writer_.reset(
         new net::URLFetcherFileWriter(file_task_runner, file_path));

[mmenke, 2013/11/07 17:02:36]

Don't we need sequenced_task_runner here, to increment the ref count?

[hashimoto, 2013/11/08 04:08:17]

chrome/browser/google_apis/task_util.h includes sequenced_task_runner.h via
message_loop_proxy.h.
Added explicit one.

   }
 }
 
 ResponseWriter::~ResponseWriter() {
 }
 
 void ResponseWriter::DisownFile() {
   DCHECK(file_writer_);
   file_writer_->DisownFile();
 }
@@ skipping 173 matching lines @@
         code = GDATA_OTHER_ERROR;
     }
   }
   return code;
 }
 
 bool UrlFetchRequestBase::CalledOnValidThread() {
   return thread_checker_.CalledOnValidThread();
 }
 
-base::TaskRunner* UrlFetchRequestBase::blocking_task_runner() const {
+base::SequencedTaskRunner* UrlFetchRequestBase::blocking_task_runner() const {
   return sender_->blocking_task_runner();
 }
 
 void UrlFetchRequestBase::OnProcessURLFetchResultsComplete() {
   sender_->RequestFinished(this);
 }
 
 void UrlFetchRequestBase::OnURLFetchComplete(const URLFetcher* source) {
   GDataErrorCode code = GetErrorCode(source);
   DVLOG(1) << "Response headers:\n" << GetResponseHeadersAsString(source);
@@ skipping 403 matching lines @@
   download_action_callback_.Run(code, temp_file);
   OnProcessURLFetchResultsComplete();
 }
 
 void DownloadFileRequestBase::RunCallbackOnPrematureFailure(
     GDataErrorCode code) {
   download_action_callback_.Run(code, base::FilePath());
 }
 
 }  // namespace google_apis