Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 639203002: gpu/khronos_glcts_support: skip egl_create_context test (Closed)

Created:
6 years, 2 months ago by U. Artie Eoff
Modified:
6 years, 2 months ago
CC:
chromium-reviews, piman+watch_chromium.org, chadv, Josh Triplett
Base URL:
https://chromium.googlesource.com/chromium/src.git@139729
Project:
chromium
Visibility:
Public.

Description

gpu/khronos_glcts_support: skip egl_create_context test In our egl_native support, the eglGetCurrentDisplay() returns EGL_NO_DISPLAY which causes this test to fail. Add this test to the test expectations so it will be skipped for now. BUG=chromium:421568, chromium:412865 R=kbr@chromium.org, piman@chromium.org TEST=Build and run khronos_glcts_test binary. Ensure test is skipped. Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>; Committed: https://crrev.com/670dd2a39a393b73466529051107ec25529f391d Cr-Commit-Position: refs/heads/master@{#299013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gpu/khronos_glcts_support/khronos_glcts_test_expectations.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
U. Artie Eoff
Hello, I'd like you to review my code.
6 years, 2 months ago (2014-10-08 23:03:46 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
6 years, 2 months ago (2014-10-08 23:09:53 UTC) #2
U. Artie Eoff
Need a lgtm from piman@ or sievers@.
6 years, 2 months ago (2014-10-09 15:00:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639203002/1
6 years, 2 months ago (2014-10-09 15:12:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/77242) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/66679) win_gpu ...
6 years, 2 months ago (2014-10-09 15:18:06 UTC) #10
U. Artie Eoff
Apparently the trybots aren't able to detect the dependency on 641913002 :-/
6 years, 2 months ago (2014-10-09 15:30:41 UTC) #11
piman
LGTM.
6 years, 2 months ago (2014-10-09 17:46:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639203002/1
6 years, 2 months ago (2014-10-09 18:44:49 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 00:02:33 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 00:03:14 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/670dd2a39a393b73466529051107ec25529f391d
Cr-Commit-Position: refs/heads/master@{#299013}

Powered by Google App Engine
This is Rietveld 408576698