Pacify Coverity when reading kExtensionsPref dictionary

Pacify Coverity when reading kExtensionsPref dictionary

CID 14614

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73450

[battre, 2011-01-31 15:29:17]

I have made the changes discussed in http://codereview.chromium.org/6271025/

[cpu_(ooo_6.6-7.5), 2011-01-31 21:44:03]

There are 50 DCHECKs in the cc file. No CHECKS. I don't want to open the doors
to that pattern.

If you feel strongly that they must be checks, my suggestion is to do this code
review with somebody who has worked extensively in this code.



On 2011/01/31 15:29:17, battre wrote:
> I have made the changes discussed in http://codereview.chromium.org/6271025/

[battre, 2011-02-01 15:23:36]

I converted the CHECKs to NOTREACHED. I am not sure whether it makes much
difference. It will crash as soon as you dereference the NULL. I think the crash
is desired behavior if the API is misused.

[Mattias Nissler (ping if slow), 2011-02-02 12:34:57]

LGTM.