[Sync] Relax checks for received XMPP messages

chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/notifier/cache_invalidation_packet_handler.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/callback.h"
@@ skipping 66 matching lines @@
       VLOG(2) << "Queueing stanza";
       QueueStanza(stanza);
       return true;
     }
     VLOG(2) << "Stanza skipped";
     return false;
   }
 
  private:
   bool IsValidCacheInvalidationIqPacket(const buzz::XmlElement* stanza) {
-    // We make sure to compare jids (which are normalized) instead of
-    // just strings -- server may use non-normalized jids in
-    // attributes.
-    //
-    // TODO(akalin): Add unit tests for this.
-    buzz::Jid to(stanza->Attr(buzz::QN_TO));
-    return
-        (MatchRequestIq(stanza, buzz::STR_SET, kQnData) &&
-         (to == GetClient()->jid()));
+    return MatchRequestIq(stanza, buzz::STR_SET, kQnData);

[sanjeevr, 2011/01/30 22:55:07]

Nit: Might want to add some comments mentioning the reasoning behind the limited
validation.

[akalin, 2011/01/31 09:54:17]

Done.

   }
 
   bool GetCacheInvalidationIqPacketData(const buzz::XmlElement* stanza,
                             std::string* data) {
     DCHECK(IsValidCacheInvalidationIqPacket(stanza));
     const buzz::XmlElement* cache_invalidation_iq_packet =
         stanza->FirstNamed(kQnData);
     if (!cache_invalidation_iq_packet) {
       LOG(ERROR) << "Could not find cache invalidation IQ packet element";
       return false;
@@ skipping 142 matching lines @@
   std::string decoded_message;
   if (!base::Base64Decode(packet, &decoded_message)) {
     LOG(ERROR) << "Could not base64-decode received message: "
                << packet;
     return;
   }
   network_endpoint->HandleInboundMessage(decoded_message);
 }
 
 }  // namespace sync_notifier