Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 639183005: cc: Stop warning about virtual+override until we can remove the virtuals (Closed)

Created:
6 years, 2 months ago by danakj
Modified:
6 years, 2 months ago
Reviewers:
ajuma, vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Stop warning about virtual+override until we can remove the virtuals This is making people ignore other presubmit warnings in all the noise. R=ajuma, enne, vmpstr Committed: https://crrev.com/4bef9dd91fa3cbb3cf08386e215b4746eab60a05 Cr-Commit-Position: refs/heads/master@{#299132}

Patch Set 1 #

Patch Set 2 : virtual-presubmit: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M cc/PRESUBMIT.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
danakj
6 years, 2 months ago (2014-10-10 15:36:38 UTC) #1
vmpstr
lgtm, please file a bug to undo this as well so it doesn't get lost.
6 years, 2 months ago (2014-10-10 15:38:05 UTC) #2
danakj
Thanks done, and added it to the comment.
6 years, 2 months ago (2014-10-10 16:12:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639183005/50001
6 years, 2 months ago (2014-10-10 16:13:25 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:50001)
6 years, 2 months ago (2014-10-10 17:18:44 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 17:19:15 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4bef9dd91fa3cbb3cf08386e215b4746eab60a05
Cr-Commit-Position: refs/heads/master@{#299132}

Powered by Google App Engine
This is Rietveld 408576698