Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 639163003: Initialize |switch_profile_link_| in the constructor. (Closed)

Created:
6 years, 2 months ago by Adrian Kuegel
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Initialize |switch_profile_link_| in the constructor. This should fix the use of the uninitialized value in the LinkClicked() method. Currently, the variable is only initialized for supervised user profiles, but LinkClicked() is also called for other profiles. BUG=422482 Committed: https://crrev.com/d3319ba3dc0c86b3c64e1fd4b11f4429de52b8db Cr-Commit-Position: refs/heads/master@{#299672}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use nullptr. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Adrian Kuegel
Scott, can you please review this CL?
6 years, 2 months ago (2014-10-13 09:06:36 UTC) #2
sky
LGTM https://codereview.chromium.org/639163003/diff/1/chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc File chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc (right): https://codereview.chromium.org/639163003/diff/1/chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc#newcode520 chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc:520: switch_profile_link_(NULL), NULL->nullptr
6 years, 2 months ago (2014-10-13 17:13:03 UTC) #3
Adrian Kuegel
https://codereview.chromium.org/639163003/diff/1/chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc File chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc (right): https://codereview.chromium.org/639163003/diff/1/chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc#newcode520 chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc:520: switch_profile_link_(NULL), On 2014/10/13 17:13:03, sky wrote: > NULL->nullptr Done.
6 years, 2 months ago (2014-10-15 09:53:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639163003/80001
6 years, 2 months ago (2014-10-15 09:53:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:80001)
6 years, 2 months ago (2014-10-15 10:41:41 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 10:42:42 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d3319ba3dc0c86b3c64e1fd4b11f4429de52b8db
Cr-Commit-Position: refs/heads/master@{#299672}

Powered by Google App Engine
This is Rietveld 408576698