Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 639133004: Merge to M38: MSE: Relax H.264 Baseline mimetype profile recognition (Closed)

Created:
6 years, 2 months ago by wolenetz
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

Merge to M38: MSE: Relax H.264 Baseline mimetype profile recognition This change lets "avc[13].42y0xx", where y >= 0x8 and xx is a valid level, be an unambiguously matched H.264 Baseline profile. This relaxes the previous requirement of a constrained baseline where y had to be 0xE. CodecParameter | Before | Now ---------------------------------------------------------------------------------------------------- avc[13].42y0xx | probably if y==E, maybe otherwise | probably if y is in [89ABCDEF], maybe otherwise BUG=408552 TBR=mmenke@chromium.org,qinmin@chromium.org,dalecurtis@chromium.org,xhwang@chromium.org TEST=Updated MediaCanPlayTypeTest.CodecSupportTest_* Review URL: https://codereview.chromium.org/626163002 Cr-Commit-Position: refs/heads/master@{#298163} (cherry picked from commit 0a0cad0dfcd0c8ea77352fb23bd2e955744355d5) Review URL: https://codereview.chromium.org/633673003 Cr-Commit-Position: refs/branch-heads/2171@{#66} Cr-Branched-From: 267aeeb8d85c8503a7fd12bd14654b8ea78d3974-refs/heads/master@{#297060} (cherry picked from commit 2f8d073aeab9292dbe43dfd03c6d75fc9f2e053e)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -7 lines) Patch
M content/browser/media/media_canplaytype_browsertest.cc View 4 chunks +44 lines, -0 lines 0 comments Download
M net/base/mime_util.cc View 3 chunks +43 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wolenetz
Merging to M38.
6 years, 2 months ago (2014-10-08 21:04:45 UTC) #1
wolenetz
On 2014/10/08 21:04:45, wolenetz wrote: > Merging to M38. Pending tree reopening.
6 years, 2 months ago (2014-10-08 21:06:38 UTC) #2
wolenetz
Committed patchset #1 (id:1) to pending queue manually as c64ab457fd25753e463307a69af1430bb29237f2 (tree was closed).
6 years, 2 months ago (2014-10-09 00:39:10 UTC) #3
wolenetz
On 2014/10/09 00:39:10, wolenetz wrote: > Committed patchset #1 (id:1) to pending queue manually as ...
6 years, 2 months ago (2014-10-09 00:46:34 UTC) #4
wolenetz
6 years, 2 months ago (2014-10-09 18:33:37 UTC) #5
Message was sent while issue was closed.
On 2014/10/09 00:46:34, wolenetz wrote:
> On 2014/10/09 00:39:10, wolenetz wrote:
> > Committed patchset #1 (id:1) to pending queue manually as
> > c64ab457fd25753e463307a69af1430bb29237f2 (tree was closed).
> 
> Note: this means the commit has not been confirmed in the real M38 branch
2125.
> It's enqueued for processing by gnumbd (which adds those
> Cr-Commit-Position/Cr-Branched-From details) once gnumbd is running again
(once
> the network outage is fixed).

This commit made it to the real M38 branch 2125 once the gnumbd bot succeeded
last night (delayed due to network issue).

Powered by Google App Engine
This is Rietveld 408576698