Chromoting browser-tests should be able to read files specified with relative paths.

chrome/test/remoting/remote_desktop_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/remoting/remote_desktop_browsertest.h"
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/json/json_reader.h"
 #include "base/path_service.h"
@@ skipping 804 matching lines @@
 
 void RemoteDesktopBrowserTest::DismissHostVersionWarningIfVisible() {
   if (HtmlElementVisible("host-needs-update-connect-button"))
     ClickOnControl("host-needs-update-connect-button");
 }
 
 void RemoteDesktopBrowserTest::SetUserNameAndPassword(
     const base::FilePath &accounts_file_path, const std::string& account_type) {
 
   // Read contents of accounts file.
-  std::string accounts_info;
-  ASSERT_TRUE(base::ReadFileToString(accounts_file_path, &accounts_info));

[anandc, 2014/10/18 02:33:45]

ReadFileToString returns an error if the file-path is relative. 
See comment here:
https://code.google.com/p/chromium/codesearch#chromium/src/base/files/file_ut...
Tests that run on the swarming slaves use relative paths, so we have to use
ReadFile instead.

+  // To handle relative paths, we'll first get the size of the file.

[Jamie, 2014/10/22 23:02:26]

Getting the size of the file is not only needed for relative file paths, so this
comment is a bit confusing. I think the comment you added to the code-review is
better and would explain why we can't use ReadFileToString here.

[anandc, 2014/10/23 00:00:40]

Done.

+  int64 accounts_file_size;
+  base::GetFileSize(accounts_file_path, &accounts_file_size);
+  // Then read the contents of the file.
+  char buf[accounts_file_size];
+  ASSERT_FALSE(base::ReadFile(accounts_file_path, buf, sizeof(buf)-1) == -1);

[Jamie, 2014/10/22 23:02:26]

Nit: spaces around the subtraction operator.

[anandc, 2014/10/23 00:00:40]

Done.

 
   // Get the root dictionary from the input json file contents.
+  std::string accounts_info(buf);
   scoped_ptr<base::Value> root(
       base::JSONReader::Read(accounts_info, base::JSON_ALLOW_TRAILING_COMMAS));
 
   const base::DictionaryValue* root_dict = NULL;
   ASSERT_TRUE(root.get() && root->GetAsDictionary(&root_dict));
 
   // Now get the dictionary for the specified account type.
   const base::DictionaryValue* account_dict = NULL;
   ASSERT_TRUE(root_dict->GetDictionary(account_type, &account_dict));
   ASSERT_TRUE(account_dict->GetString(kUserName, &username_));
@@ skipping 19 matching lines @@
 // static
 bool RemoteDesktopBrowserTest::IsEnabled(
     content::WebContents* client_web_content,
     const std::string& element_name) {
   return !ExecuteScriptAndExtractBool(
     client_web_content,
     "document.getElementById(\"" + element_name + "\").disabled");
 }
 
 }  // namespace remoting