src/ia32/full-codegen-ia32.cc - Issue 639123009: Classes: Add basic support for properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 639123009: Classes: Add basic support for properties (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Use define data property instead Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 8e9c7084b95b74c41376197547bc2e7510078aa6..0e064b4fe6b18e5b130abf8eb2fe69a98ea1d3d7 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -2442,8 +2442,8 @@ void FullCodeGenerator::EmitClassDefineProperties(ClassLiteral* lit) {

}

VisitForStackValue(key);

VisitForStackValue(value);

- __ push(Immediate(Smi::FromInt(SLOPPY))); // Strict mode

- __ CallRuntime(Runtime::kSetProperty, 4);

+ __ push(Immediate(Smi::FromInt(NONE)));

+ __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4);

Dmitry Lomov (no reviews) 2014/10/21 06:17:05 Ah, that's better, now I understand :) This one is

break;

case ObjectLiteral::Property::GETTER: {

« no previous file with comments | « no previous file | test/mjsunit/harmony/classes.js » ('j') | no next file with comments »