src/full-codegen.cc - Issue 639123009: Classes: Add basic support for properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen.cc

Issue 639123009: Classes: Add basic support for properties (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen.cc

diff --git a/src/full-codegen.cc b/src/full-codegen.cc

index 61a6eac6349a73896b88b5676b8660552affb151..b3b04443cf72688f482a8c8e385a46bc41461fab 100644

--- a/src/full-codegen.cc

+++ b/src/full-codegen.cc

@@ -1567,10 +1567,8 @@ void FullCodeGenerator::VisitClassLiteral(ClassLiteral* lit) {

__ Push(Smi::FromInt(lit->start_position()));

__ Push(Smi::FromInt(lit->end_position()));

- // TODO(arv): Process methods

__ CallRuntime(Runtime::kDefineClass, 6);

- context()->Plug(result_register());

+ EmitClassDefineProperties(lit);

Dmitry Lomov (no reviews) 2014/10/18 08:30:32 nit: keep plugging context here - this is a result

}