Classes: Add basic support for properties

src/ia32/full-codegen-ia32.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #if V8_TARGET_ARCH_IA32
 
 #include "src/code-factory.h"
 #include "src/code-stubs.h"
@@ skipping 2397 matching lines @@
       break;
     default:
       UNREACHABLE();
   }
 
   __ bind(&done);
   context()->Plug(eax);
 }
 
 
+void FullCodeGenerator::EmitClassDefineProperties(ClassLiteral* lit) {
+  // ctor is in eax.
+  DCHECK(lit != NULL);
+  __ push(eax);
+
+  Register scratch = ebx;
+  __ mov(scratch, FieldOperand(eax, JSFunction::kPrototypeOrInitialMapOffset));

[Dmitry Lomov (no reviews), 2014/10/18 08:30:33]

Loading prototype is an operation that requires access check :(
So you need to call GetPrototype here, just like for super(...) call.
I guess extract that into a separate EmitGetPrototype.

+  __ push(scratch);
+
+  AccessorTable accessor_table(zone());
+  for (int i = 0; i < lit->properties()->length(); i++) {
+    ObjectLiteral::Property* property = lit->properties()->at(i);
+    Literal* key = property->key()->AsLiteral();
+    Expression* value = property->value();
+    DCHECK(key != NULL);
+
+    switch (property->kind()) {
+      case ObjectLiteral::Property::CONSTANT:
+      case ObjectLiteral::Property::MATERIALIZED_LITERAL:
+      case ObjectLiteral::Property::COMPUTED:
+        if (property->is_static()) {
+          __ push(Operand(esp, kPointerSize));  // constructor
+        } else {
+          __ push(Operand(esp, 0));  // prototype
+        }
+        VisitForStackValue(key);
+        VisitForStackValue(value);
+        __ push(Immediate(Smi::FromInt(SLOPPY)));  // Strict mode
+        __ CallRuntime(Runtime::kSetProperty, 4);

[Dmitry Lomov (no reviews), 2014/10/18 08:30:33]

You should use StoreIC here (see EmitKeyedPropertyAssignment for how it is done)

[Dmitry Lomov (no reviews), 2014/10/18 09:04:59]

s/Keyed/Named/ of course.
Maybe given how much runtime calling is going on here anyway, maybe it's not
worth it yet to install ICs here

[arv (Not doing code reviews), 2014/10/20 20:22:31]

I'm not sure that is correct? We are not doing assignment here but define.

+        break;
+
+      case ObjectLiteral::Property::GETTER: {
+        ObjectLiteral::Accessors *accessors =
+            accessor_table.lookup(key)->second;
+        accessors->getter = value;
+        if (property->is_static()) {
+          __ push(Operand(esp, kPointerSize));  // constructor
+        } else {
+          __ push(Operand(esp, 0));  // prototype
+        }
+        VisitForStackValue(key);
+        EmitAccessor(accessors->getter);
+        EmitAccessor(accessors->setter);
+        __ push(Immediate(Smi::FromInt(NONE)));
+        __ CallRuntime(Runtime::kDefineAccessorPropertyUnchecked, 5);
+        break;
+      }
+
+      case ObjectLiteral::Property::SETTER: {
+        ObjectLiteral::Accessors *accessors =
+            accessor_table.lookup(key)->second;
+        accessors->setter = value;
+        if (property->is_static()) {
+          __ push(Operand(esp, kPointerSize));  // constructor
+        } else {
+          __ push(Operand(esp, 0));  // prototype
+        }
+        VisitForStackValue(key);
+        EmitAccessor(accessors->getter);
+        EmitAccessor(accessors->setter);
+        __ push(Immediate(Smi::FromInt(NONE)));
+        __ CallRuntime(Runtime::kDefineAccessorPropertyUnchecked, 5);
+        break;
+      }
+
+      case ObjectLiteral::Property::PROTOTYPE:
+        // TODO(arv): Implement
+
+      default:
+        UNREACHABLE();
+    }
+  }
+
+  // prototype
+  __ CallRuntime(Runtime::kToFastProperties, 1);
+
+  // constructor
+  __ CallRuntime(Runtime::kToFastProperties, 1);
+
+  context()->Plug(eax);
+}
+
+
+
 void FullCodeGenerator::EmitBinaryOp(BinaryOperation* expr,
                                      Token::Value op,
                                      OverwriteMode mode) {
   __ pop(edx);
   Handle<Code> code = CodeFactory::BinaryOpIC(isolate(), op, mode).code();
   JumpPatchSite patch_site(masm_);    // unbound, signals no inlined smi code.
   CallIC(code, expr->BinaryOperationFeedbackId());
   patch_site.EmitPatchInfo();
   context()->Plug(eax);
 }
@@ skipping 2715 matching lines @@
   DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
             Assembler::target_address_at(call_target_address,
                                          unoptimized_code));
   return OSR_AFTER_STACK_CHECK;
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32