Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 639113004: [android_webview] Hardcode the default text encoding to UTF-8. (Closed)

Created:
6 years, 2 months ago by mkosiba (inactive)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[android_webview] Hardcode the default text encoding to UTF-8. The WebView will use a fixed default value for the text encoding instead of getting it from the platform. This is in attempt to unify behavior between devices. BUG=422366 Committed: https://crrev.com/72ea36f782c38afb93387afe3cb6cf69ba9ab429 Cr-Commit-Position: refs/heads/master@{#299287}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : remove spurious newline from AwResources #

Patch Set 4 : update AwSettingsTest.testDefaultTextEncodingWithTwoViews #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -56 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/buildbot/aosp_manifest.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/common/aw_resource.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwResource.java View 1 2 2 chunks +0 lines, -12 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwSettings.java View 1 2 chunks +1 line, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_resource.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
D android_webview/test/shell/res/values/strings.xml View 1 1 chunk +0 lines, -11 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellResourceProvider.java View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
mkosiba (inactive)
PTAL
6 years, 2 months ago (2014-10-10 16:51:31 UTC) #2
mkosiba (inactive)
+jam Jam, looks like you removed all of the usage of GetDefaultEncoding so it can ...
6 years, 2 months ago (2014-10-10 17:17:29 UTC) #4
benm (inactive)
lgtm
6 years, 2 months ago (2014-10-10 17:19:44 UTC) #5
mkosiba (inactive)
+jochen@ for OWNERS stamp in this timezone :)
6 years, 2 months ago (2014-10-13 08:33:46 UTC) #7
jochen (gone - plz use gerrit)
lgtm.
6 years, 2 months ago (2014-10-13 08:35:33 UTC) #8
mkosiba (inactive)
+Mikhail for AwSettings/AwSettingsTest.
6 years, 2 months ago (2014-10-13 08:38:38 UTC) #10
mnaganov (inactive)
awsettings LGTM
6 years, 2 months ago (2014-10-13 10:14:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639113004/340001
6 years, 2 months ago (2014-10-13 10:16:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639113004/590001
6 years, 2 months ago (2014-10-13 11:28:55 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:590001)
6 years, 2 months ago (2014-10-13 12:33:07 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 12:33:47 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/72ea36f782c38afb93387afe3cb6cf69ba9ab429
Cr-Commit-Position: refs/heads/master@{#299287}

Powered by Google App Engine
This is Rietveld 408576698