Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Unified Diff: tests/fixedfeaturecpu/nacl.scons

Issue 639113003: Add nacl-clang testing to SCons (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: review 2 Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/fixedfeaturecpu/nacl.scons
diff --git a/tests/fixedfeaturecpu/nacl.scons b/tests/fixedfeaturecpu/nacl.scons
index fbe82b962146bf7612c223a3be05880150993ad7..46983e3fb81349b0a2eafb6e87d0f93575b381e1 100644
--- a/tests/fixedfeaturecpu/nacl.scons
+++ b/tests/fixedfeaturecpu/nacl.scons
@@ -62,8 +62,13 @@ elif env.Bit('nacl_glibc'):
expect_x87_Z_status=1
else:
if env.Bit('target_x86_32'):
- # 32-bit newlib: passes
- expect_null_Z_status=0
+ # 32-bit newlib: passes, except nacl-clang's ff_null_z for reasons which
+ # are uknown because ncval is broken and ncval_new doesn't support
jvoung (off chromium) 2014/10/09 19:05:01 uknown -> unknown
Derek Schuff 2014/10/09 22:22:00 Done.
+ # FF mode.
+ if env.Bit('nacl_clang'):
+ expect_null_Z_status=1
+ else:
+ expect_null_Z_status=0
expect_sse_Z_status=1
expect_x87_Z_status=1
elif env.Bit('target_x86_64'):
@@ -120,7 +125,7 @@ if not env.Bit('bitcode'):
# http://code.google.com/p/nativeclient/issues/detail?id=2692
if not env.Bit('target_x86_64') and not env.Bit('bitcode'):
x87_env = env.Clone()
- x87_env.Append(CCFLAGS=['-mfpmath=387'])
+ x87_env.Append(CCFLAGS=['-mfpmath=387', '-mno-sse'])
x87_o = x87_env.ComponentObject('ff_hello_world_x87.o', 'ff_hello_world.c')
ff_hello_world_x87_nexe = x87_env.ComponentProgram(
'ff_hello_world_x87',
« SConstruct ('K') | « tests/exception_test/nacl.scons ('k') | tests/gdb/gdb_test_guest.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698