Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: tests/signal_handler_single_step/nacl.scons

Issue 639113003: Add nacl-clang testing to SCons (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: ncbray comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/gdb/gdb_test_guest.c ('k') | tests/stubout_mode/nacl.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/signal_handler_single_step/nacl.scons
diff --git a/tests/signal_handler_single_step/nacl.scons b/tests/signal_handler_single_step/nacl.scons
index 806bcacc9b58c5828324d16f55241e861d3b9d7d..1bc182069df0191883583f9774e3cee048b425bb 100644
--- a/tests/signal_handler_single_step/nacl.scons
+++ b/tests/signal_handler_single_step/nacl.scons
@@ -27,6 +27,12 @@ if env.Bit('host_windows'):
# restore %cs to its saved value on return from a signal handler.
if env.Bit('host_mac'):
Return()
+# nacl-clang's integrated assembler expands "naclcall" to a sequence which
+# separates the push of the return address from the jump, and so breaks the
+# test's expectations for the stack pointer.
+# TODO(dschuff): re-enable this test after we switch to gas with nacl-clang
+if env.Bit('nacl_clang'):
+ Return()
if env.Bit('build_x86'):
step_test_guest = env.ComponentProgram(
« no previous file with comments | « tests/gdb/gdb_test_guest.c ('k') | tests/stubout_mode/nacl.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698