Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: src/trusted/validator/nacl.scons

Issue 639113003: Add nacl-clang testing to SCons (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: ncbray comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « site_scons/site_tools/naclsdk.py ('k') | src/untrusted/stubs/crti_x86_32.S » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator/nacl.scons
diff --git a/src/trusted/validator/nacl.scons b/src/trusted/validator/nacl.scons
index d6e16f6ebe75ab222c795f7732b4e5e705f404d9..c082a8b77484cc1ba0991abfe81e421ece7a2b61 100644
--- a/src/trusted/validator/nacl.scons
+++ b/src/trusted/validator/nacl.scons
@@ -30,4 +30,6 @@ node = env.CommandTest(
env.AddNodeToTestSuite(node, ['small_tests'], 'run_ncval_annotate_test',
# PNaCl does not allow the inline assembly that
# we use to test this.
- is_broken=env.Bit('bitcode'))
+ # The test also hardcodes use of nacl-gcc and doesn't
+ # really need to run more than once anyway.
+ is_broken=env.Bit('bitcode') or env.Bit('nacl_clang'))
« no previous file with comments | « site_scons/site_tools/naclsdk.py ('k') | src/untrusted/stubs/crti_x86_32.S » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698