Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 639113002: [NaCl SDK] nacl_io: Rename termios entry points. (Closed)

Created:
6 years, 2 months ago by Sam Clegg
Modified:
6 years, 2 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: Rename termios entry points. This allows us to clearly distinguish between entry points that are part of termios and the top level ones which are trying eliminate (by moving them to the C libraries). Committed: https://crrev.com/6c12b9c55841c8b0d1f087a232a16662eac7251d Cr-Commit-Position: refs/heads/master@{#299032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -233 lines) Patch
M native_client_sdk/src/libraries/nacl_io/library.dsc View 2 chunks +11 lines, -11 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/cfgetispeed.c View 1 chunk +0 lines, -20 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/cfgetospeed.c View 1 chunk +0 lines, -20 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/cfsetispeed.c View 1 chunk +0 lines, -20 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/cfsetospeed.c View 1 chunk +0 lines, -21 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/cfsetspeed.c View 1 chunk +0 lines, -22 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/tcdrain.c View 1 chunk +0 lines, -23 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/tcflow.c View 1 chunk +0 lines, -22 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/tcflush.c View 1 chunk +0 lines, -20 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/tcgetattr.c View 1 chunk +0 lines, -21 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/tcsendbreak.c View 1 chunk +0 lines, -24 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/tcsetattr.c View 1 chunk +0 lines, -20 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/termios/cfgetispeed.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/termios/cfgetospeed.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/termios/cfsetispeed.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/termios/cfsetospeed.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/termios/cfsetspeed.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/termios/tcdrain.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/termios/tcflow.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/termios/tcflush.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/termios/tcgetattr.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/termios/tcsendbreak.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/termios/tcsetattr.c View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam Clegg
6 years, 2 months ago (2014-10-08 18:36:49 UTC) #2
binji
lgtm
6 years, 2 months ago (2014-10-08 19:07:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639113002/1
6 years, 2 months ago (2014-10-10 01:05:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 01:21:15 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 02:04:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c12b9c55841c8b0d1f087a232a16662eac7251d
Cr-Commit-Position: refs/heads/master@{#299032}

Powered by Google App Engine
This is Rietveld 408576698