chromeos/ime/composition_text.h - Issue 639103003: Support invisible underline for IME composition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/ime/composition_text.h

Issue 639103003: Support invisible underline for IME composition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: renamed 'invisible' to 'noUnderline'. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/ime/composition_text.h

diff --git a/chromeos/ime/composition_text.h b/chromeos/ime/composition_text.h

index b79efd9b34ac51df41de7697a1c9ee7a70194b84..9cc0d1380b6ae4c761f7cb7e831d8497f921cc8c 100644

--- a/chromeos/ime/composition_text.h

+++ b/chromeos/ime/composition_text.h

@@ -19,7 +19,8 @@ class CHROMEOS_EXPORT CompositionText {

enum UnderlineType {

COMPOSITION_TEXT_UNDERLINE_SINGLE = 1,

COMPOSITION_TEXT_UNDERLINE_DOUBLE = 2,

- COMPOSITION_TEXT_UNDERLINE_ERROR = 4,

+ COMPOSITION_TEXT_UNDERLINE_NONE = 4,

Seigo Nonaka 2014/10/13 06:23:10 nit: this value is no longer being unique bit valu

+ COMPOSITION_TEXT_UNDERLINE_ERROR = 8,

};

struct UnderlineAttribute {