Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 639103003: Support invisible underline for IME composition. (Closed)

Created:
6 years, 2 months ago by Shu Chen
Modified:
6 years, 2 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support invisible underline for IME composition. This CL adds a new 'noUnderline' enum value in the segment style in chrome.input.ime.setComposition(). BUG=407576 TEST=Verified on linux_chromeos with a test IME extension. Committed: https://crrev.com/c00b05d44f1836aa9bb192be7dea208d8d7dd5e6 Cr-Commit-Position: refs/heads/master@{#299414}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : renamed 'invisible' to 'noUnderline'. #

Total comments: 3

Patch Set 4 : nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_interface.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M chrome/common/extensions/api/input_ime.json View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/ime/composition_text.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/ime/input_method_chromeos.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Shu Chen
Nona/Ben, can you please review this cl? Thanks
6 years, 2 months ago (2014-10-13 04:03:40 UTC) #2
Seigo Nonaka
lgtm with nit pick. https://codereview.chromium.org/639103003/diff/110002/chrome/common/extensions/api/input_ime.json File chrome/common/extensions/api/input_ime.json (right): https://codereview.chromium.org/639103003/diff/110002/chrome/common/extensions/api/input_ime.json#newcode104 chrome/common/extensions/api/input_ime.json:104: "description": "How to render this ...
6 years, 2 months ago (2014-10-13 06:23:10 UTC) #3
Shu Chen
https://codereview.chromium.org/639103003/diff/110002/chrome/common/extensions/api/input_ime.json File chrome/common/extensions/api/input_ime.json (right): https://codereview.chromium.org/639103003/diff/110002/chrome/common/extensions/api/input_ime.json#newcode104 chrome/common/extensions/api/input_ime.json:104: "description": "How to render this segment", On 2014/10/13 06:23:10, ...
6 years, 2 months ago (2014-10-13 06:28:11 UTC) #4
not at google - send to devlin
lgtm
6 years, 2 months ago (2014-10-13 23:40:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639103003/170001
6 years, 2 months ago (2014-10-14 00:42:38 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:170001)
6 years, 2 months ago (2014-10-14 01:27:27 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 01:28:06 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/c00b05d44f1836aa9bb192be7dea208d8d7dd5e6
Cr-Commit-Position: refs/heads/master@{#299414}

Powered by Google App Engine
This is Rietveld 408576698