Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 639043003: remove new OVERRIDEs added to mojo/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
brettw, yzshen1, qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove new OVERRIDEs added to mojo/ BUG=417463 Committed: https://crrev.com/c7628a4898078a6b974f4cd64c52d972d914a402 Cr-Commit-Position: refs/heads/master@{#299278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M mojo/services/network/udp_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mostyn Bramley-Moore
@brettw: please take a look at this trivial fixup to https://codereview.chromium.org/596383002
6 years, 2 months ago (2014-10-13 09:03:41 UTC) #2
qsr
lgtm
6 years, 2 months ago (2014-10-13 09:32:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639043003/1
6 years, 2 months ago (2014-10-13 09:39:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 10:34:20 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c7628a4898078a6b974f4cd64c52d972d914a402 Cr-Commit-Position: refs/heads/master@{#299278}
6 years, 2 months ago (2014-10-13 10:35:08 UTC) #8
yzshen1
6 years, 2 months ago (2014-10-13 16:10:50 UTC) #9 
Sorry, old habits die hard...

LGTM

On Mon, Oct 13, 2014 at 3:35 AM, <commit-bot@chromium.org> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/c7628a4898078a6b974f4cd64c52d972d914a402
> Cr-Commit-Position: refs/heads/master@{#299278}
>
> https://codereview.chromium.org/639043003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698