Source/web/ContextMenuClientImpl.cpp - Issue 639023004: Oilpan: move HistoryItem to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ContextMenuClientImpl.cpp

Issue 639023004: Oilpan: move HistoryItem to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ContextMenuClientImpl.cpp

diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/ContextMenuClientImpl.cpp

index 8eb3d7147be9cb84ac47811e0a5179c9ed2a73bb..03f85fa384f5d9a883dfa9d5a62ac21bb0f2d20a 100644

--- a/Source/web/ContextMenuClientImpl.cpp

+++ b/Source/web/ContextMenuClientImpl.cpp

@@ -307,7 +307,7 @@ void ContextMenuClientImpl::showContextMenu(const ContextMenu* defaultMenu)

data.pageURL = urlFromFrame(m_webView->mainFrameImpl()->frame());

if (selectedFrame != m_webView->mainFrameImpl()->frame()) {

data.frameURL = urlFromFrame(selectedFrame);

- RefPtr<HistoryItem> historyItem = selectedFrame->loader().currentItem();

+ RefPtrWillBeRawPtr<HistoryItem> historyItem = selectedFrame->loader().currentItem();

if (historyItem)

data.frameHistoryItem = WebHistoryItem(historyItem);

}

« no previous file with comments | « Source/core/loader/HistoryItem.cpp ('k') | Source/web/WebHistoryItem.cpp » ('j') | no next file with comments »