Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 639013003: Update old tools to allow MultiPictureDraw rendering (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update old tools to allow MultiPictureDraw rendering I'll post a separate patch for nanobench and dm Committed: https://skia.googlesource.com/skia/+/78c71272fb26852bf3d2ca31785e61d4a598af82

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comments #

Patch Set 3 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -95 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/CopyTilesRenderer.h View 1 chunk +2 lines, -1 line 0 comments Download
M tools/CopyTilesRenderer.cpp View 4 chunks +12 lines, -2 lines 0 comments Download
M tools/PictureBenchmark.h View 3 chunks +1 line, -5 lines 0 comments Download
M tools/PictureBenchmark.cpp View 3 chunks +10 lines, -17 lines 0 comments Download
M tools/PictureRenderer.h View 6 chunks +12 lines, -4 lines 0 comments Download
M tools/PictureRenderer.cpp View 1 12 chunks +90 lines, -29 lines 0 comments Download
M tools/bbh_shootout.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M tools/bench_pictures_main.cpp View 3 chunks +2 lines, -13 lines 0 comments Download
M tools/render_pictures_main.cpp View 3 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
robertphillips
6 years, 2 months ago (2014-10-08 19:09:52 UTC) #2
jvanverth1
LGTM + comment https://codereview.chromium.org/639013003/diff/1/tools/PictureRenderer.cpp File tools/PictureRenderer.cpp (right): https://codereview.chromium.org/639013003/diff/1/tools/PictureRenderer.cpp#newcode691 tools/PictureRenderer.cpp:691: Maybe a comment or two explaining ...
6 years, 2 months ago (2014-10-08 19:16:28 UTC) #3
robertphillips
https://codereview.chromium.org/639013003/diff/1/tools/PictureRenderer.cpp File tools/PictureRenderer.cpp (right): https://codereview.chromium.org/639013003/diff/1/tools/PictureRenderer.cpp#newcode691 tools/PictureRenderer.cpp:691: On 2014/10/08 19:16:28, jvanverth1 wrote: > Maybe a comment ...
6 years, 2 months ago (2014-10-08 19:26:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639013003/20001
6 years, 2 months ago (2014-10-08 19:27:43 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
6 years, 2 months ago (2014-10-09 01:18:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639013003/40001
6 years, 2 months ago (2014-10-09 11:51:20 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 11:59:24 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 78c71272fb26852bf3d2ca31785e61d4a598af82

Powered by Google App Engine
This is Rietveld 408576698