Create autofill subdirectory in chrome/renderer

Create autofill subdirectory in chrome/renderer

BUG=none
TEST=compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73081

[Ilya Sherman, 2011-01-29 02:14:19]

(1) password autocomplete seems like it should live in the autofill directory
too,

Done.

  (2) the words "agent", "dispatcher", "proxy" are used... possible replacement
for "helper"?

Renamed AutoFillHelper to AutoFillAgent

  (3) wondering about rationalizing autocomplete/autofill to password_autofill,
form_autofill, field_autofill...

Renamed PasswordAutocompleteManager to PasswordAutoFillManager.  I prefer
"autocomplete" to "field autofill", both because it matches the HTML
'autoComplete' attribute and because it really serves as a completion to what
the user typed.  This only affects one pair of files in the browser/ directory;
I'll move those into the browser/autofill/ directory in a separate patch.

[dhollowa, 2011-01-29 02:52:58]

For symmetry... form_manager -> form_autofill_manager, to match
password_autofill_manager?


On 2011/01/29 02:14:19, Ilya Sherman wrote:
> (1) password autocomplete seems like it should live in the autofill directory
> too,
> 
> Done.
> 
>   (2) the words "agent", "dispatcher", "proxy" are used... possible
replacement
> for "helper"?
> 
> Renamed AutoFillHelper to AutoFillAgent
> 
>   (3) wondering about rationalizing autocomplete/autofill to
password_autofill,
> form_autofill, field_autofill...
> 
> Renamed PasswordAutocompleteManager to PasswordAutoFillManager.  I prefer
> "autocomplete" to "field autofill", both because it matches the HTML
> 'autoComplete' attribute and because it really serves as a completion to what
> the user typed.  This only affects one pair of files in the browser/
directory;
> I'll move those into the browser/autofill/ directory in a separate patch.

[Ilya Sherman, 2011-01-29 04:06:20]

On 2011/01/29 02:52:58, dhollowa wrote:
> For symmetry... form_manager -> form_autofill_manager, to match
> password_autofill_manager?

As mentioned offline, I'd like to make that change in a separate cl, just to
keep this one and the ones branched off it manageable.  Logged this as
http://crbug.com/71257 to make sure I remember to come back to it.

[dhollowa, 2011-01-29 04:33:54]

http://codereview.chromium.org/6390006/diff/20001/chrome/renderer/autofill/fo...
File chrome/renderer/autofill/form_manager.h (right):

http://codereview.chromium.org/6390006/diff/20001/chrome/renderer/autofill/fo...
chrome/renderer/autofill/form_manager.h:26: namespace autofill {
I think we should not use namespaces here.  The namespace is baked into the
names (or will be in the case of form_manager).

[dhollowa, 2011-01-29 05:09:44]

As discussed: happy medium is (1) keep the |autofill| namespace, (2) have
|using| directives in .cc files, (3) but not (according to style guide) in .h
files.

On 2011/01/29 04:33:54, dhollowa wrote:
>
http://codereview.chromium.org/6390006/diff/20001/chrome/renderer/autofill/fo...
> File chrome/renderer/autofill/form_manager.h (right):
> 
>
http://codereview.chromium.org/6390006/diff/20001/chrome/renderer/autofill/fo...
> chrome/renderer/autofill/form_manager.h:26: namespace autofill {
> I think we should not use namespaces here.  The namespace is baked into the
> names (or will be in the case of form_manager).

[Ilya Sherman, 2011-01-29 05:22:06]

On 2011/01/29 05:09:44, dhollowa wrote:
> As discussed: happy medium is (1) keep the |autofill| namespace, (2) have
> |using| directives in .cc files, (3) but not (according to style guide) in .h
> files.

Done (with slight reservations ;) )

[dhollowa, 2011-01-29 05:30:20]

LGTM.

http://codereview.chromium.org/6390006/diff/21016/chrome/renderer/autofill/fo...
File chrome/renderer/autofill/form_autocomplete_browsertest.cc (right):

http://codereview.chromium.org/6390006/diff/21016/chrome/renderer/autofill/fo...
chrome/renderer/autofill/form_autocomplete_browsertest.cc:5: #include
"chrome/common/autofill_messages.h"
Funny.  No changes.  Why is this listed then?

http://codereview.chromium.org/6390006/diff/21016/chrome/test/render_view_tes...
File chrome/test/render_view_test.cc (right):

http://codereview.chromium.org/6390006/diff/21016/chrome/test/render_view_tes...
chrome/test/render_view_test.cc:42: using autofill::AutoFillAgent;
This should be above WebKit namespace.

[Ilya Sherman, 2011-01-29 05:42:46]

http://codereview.chromium.org/6390006/diff/21016/chrome/renderer/autofill/fo...
File chrome/renderer/autofill/form_autocomplete_browsertest.cc (right):

http://codereview.chromium.org/6390006/diff/21016/chrome/renderer/autofill/fo...
chrome/renderer/autofill/form_autocomplete_browsertest.cc:5: #include
"chrome/common/autofill_messages.h"
On 2011/01/29 05:30:20, dhollowa wrote:
> Funny.  No changes.  Why is this listed then?

The file moved into the autofill/ directory ;)

http://codereview.chromium.org/6390006/diff/21016/chrome/test/render_view_tes...
File chrome/test/render_view_test.cc (right):

http://codereview.chromium.org/6390006/diff/21016/chrome/test/render_view_tes...
chrome/test/render_view_test.cc:42: using autofill::AutoFillAgent;
On 2011/01/29 05:30:20, dhollowa wrote:
> This should be above WebKit namespace.

As discussed offline, going with unix sort's order: lowercase follows uppercase