Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2004)

Unified Diff: Tools/Scripts/webkitpy/common/config/urls.py

Issue 638993002: Remove old WebKit urls from webkitpy. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/common/config/urls_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/common/config/urls.py
diff --git a/Tools/Scripts/webkitpy/common/config/urls.py b/Tools/Scripts/webkitpy/common/config/urls.py
index 331bb06422e01adb0fc9dfe15f43d0deb1f74119..0d504381dfbce9b99ae1e08cd9e7dac7285d5989 100644
--- a/Tools/Scripts/webkitpy/common/config/urls.py
+++ b/Tools/Scripts/webkitpy/common/config/urls.py
@@ -30,11 +30,7 @@ import re
def view_source_url(local_path):
- return "http://trac.webkit.org/browser/trunk/%s" % local_path
-
-
-def view_revision_url(revision_number):
- return "http://trac.webkit.org/changeset/%s" % revision_number
+ return "https://src.chromium.org/viewvc/blink/trunk/%s" % local_path
def chromium_results_url_base():
@@ -56,42 +52,8 @@ def chromium_accumulated_results_url_base_for_builder(builder_name):
chromium_lkgr_url = "http://chromium-status.appspot.com/lkgr"
contribution_guidelines = "http://webkit.org/coding/contributing.html"
-bug_server_domain = "webkit.org"
-bug_server_host = "bugs." + bug_server_domain
-_bug_server_regex = "https?://%s/" % re.sub('\.', '\\.', bug_server_host)
-bug_server_url = "https://%s/" % bug_server_host
-bug_url_long = _bug_server_regex + r"show_bug\.cgi\?id=(?P<bug_id>\d+)(&ctype=xml|&excludefield=attachmentdata)*"
-bug_url_short = r"https?\://%s/b/(?P<bug_id>\d+)" % bug_server_domain
-
-attachment_url = _bug_server_regex + r"attachment\.cgi\?id=(?P<attachment_id>\d+)(&action=(?P<action>\w+))?"
-direct_attachment_url = r"https?://bug-(?P<bug_id>\d+)-attachments.%s/attachment\.cgi\?id=(?P<attachment_id>\d+)" % bug_server_domain
-
-buildbot_url = "http://build.webkit.org"
chromium_buildbot_url = "http://build.chromium.org/p/chromium.webkit"
chromium_webkit_sheriff_url = "http://build.chromium.org/p/chromium.webkit/sheriff_webkit.js"
omahaproxy_url = "http://omahaproxy.appspot.com/"
-
-def parse_bug_id(string):
- if not string:
- return None
- match = re.search(bug_url_short, string)
- if match:
- return int(match.group('bug_id'))
- match = re.search(bug_url_long, string)
- if match:
- return int(match.group('bug_id'))
- return None
-
-
-def parse_attachment_id(string):
- if not string:
- return None
- match = re.search(attachment_url, string)
- if match:
- return int(match.group('attachment_id'))
- match = re.search(direct_attachment_url, string)
- if match:
- return int(match.group('attachment_id'))
- return None
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/common/config/urls_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698