src/log.cc - Issue 638943002: Resolve race between starting the profiler thread and the logging timer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log.cc

Issue 638943002: Resolve race between starting the profiler thread and the logging timer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/log.cc

diff --git a/src/log.cc b/src/log.cc

index db1f3cf880e63f7a4794c39618770f81ea3b22cb..265895aeef7a5f6420a2c5b883b5868b17a26e7f 100644

--- a/src/log.cc

+++ b/src/log.cc

@@ -1866,14 +1866,14 @@ bool Logger::SetUp(Isolate* isolate) {

is_logging_ = true;

}

+ if (FLAG_log_internal_timer_events || FLAG_prof) timer_.Start();

if (FLAG_prof) {

profiler_ = new Profiler(isolate);

is_logging_ = true;

profiler_->Engage();

}

- if (FLAG_log_internal_timer_events || FLAG_prof) timer_.Start();

return true;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »