Introduce SVGPaintServer

Source/core/paint/SVGPaintServer.cpp

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "core/paint/SVGPaintServer.h"
+
+#include "core/rendering/style/RenderStyle.h"
+#include "core/rendering/style/SVGRenderStyle.h"
+#include "core/rendering/svg/RenderSVGResourceSolidColor.h"
+#include "core/rendering/svg/SVGRenderSupport.h"
+#include "platform/graphics/GraphicsContext.h"
+#include "platform/graphics/GraphicsContextStateSaver.h"
+
+namespace blink {
+
+SVGPaintServer::SVGPaintServer(Color color)
+    : m_color(color)
+{
+}
+
+SVGPaintServer::SVGPaintServer(PassRefPtr<Gradient> gradient)
+    : m_gradient(gradient)
+    , m_color(Color::black)
+{
+}
+
+SVGPaintServer::SVGPaintServer(PassRefPtr<Pattern> pattern)
+    : m_pattern(pattern)
+    , m_color(Color::black)
+{
+}
+
+void SVGPaintServer::apply(GraphicsContext& context, RenderSVGResourceMode resourceMode, GraphicsContextStateSaver* stateSaver)
+{
+    ASSERT(resourceMode == ApplyToFillMode || resourceMode == ApplyToStrokeMode);
+    if (stateSaver && (m_gradient || m_pattern))
+        stateSaver->saveIfNeeded();
+
+    if (resourceMode == ApplyToFillMode) {
+        if (m_pattern)
+            context.setFillPattern(m_pattern);
+        else if (m_gradient)
+            context.setFillGradient(m_gradient);
+        else
+            context.setFillColor(m_color);
+    } else {
+        if (m_pattern)
+            context.setStrokePattern(m_pattern);
+        else if (m_gradient)
+            context.setStrokeGradient(m_gradient);
+        else
+            context.setStrokeColor(m_color);
+    }
+}
+
+PassOwnPtr<SVGPaintServer> SVGPaintServer::requestForRenderer(RenderObject& renderer, RenderStyle* style, RenderSVGResourceModeFlags resourceModeFlags)
+{
+    ASSERT(style);
+    RenderSVGResourceMode resourceMode = static_cast<RenderSVGResourceMode>(resourceModeFlags & (ApplyToFillMode | ApplyToStrokeMode));
+    ASSERT(resourceMode == ApplyToFillMode || resourceMode == ApplyToStrokeMode);
+
+    bool hasFallback = false;
+    RenderSVGResource* paintingResource = RenderSVGResource::requestPaintingResource(resourceMode, &renderer, style, hasFallback);
+    if (!paintingResource)
+        return nullptr;
+
+    OwnPtr<SVGPaintServer> paintServer = paintingResource->preparePaintServer(&renderer, style, resourceModeFlags);
+    if (paintServer)
+        return paintServer.release();
+    if (hasFallback)
+        return adoptPtr(new SVGPaintServer(RenderSVGResource::sharedSolidPaintingResource()->color()));
+    return nullptr;
+}
+
+bool SVGPaintServer::updateGraphicsContext(GraphicsContextStateSaver& stateSaver, RenderStyle* style, RenderObject& renderer, RenderSVGResourceModeFlags resourceModeFlags)
+{
+    ASSERT(style);
+
+    RenderSVGResourceMode resourceMode = static_cast<RenderSVGResourceMode>(resourceModeFlags & (ApplyToFillMode | ApplyToStrokeMode));
+    ASSERT(resourceMode == ApplyToFillMode || resourceMode == ApplyToStrokeMode);
+
+    GraphicsContext* context = stateSaver.context();
+    if (SVGRenderSupport::isRenderingClipPathAsMaskImage(renderer)) {
+        if (resourceMode == ApplyToStrokeMode)
+            return false;
+        context->setAlphaAsFloat(1);
+        context->setFillColor(SVGRenderStyle::initialFillPaintColor());
+        return true;
+    }
+
+    OwnPtr<SVGPaintServer> paintServer = requestForRenderer(renderer, style, resourceModeFlags);

[f(malita), 2014/10/10 15:49:07]

If we're not caching these, it seems wasteful to allocate them dynamically (even
with WTF_MAKE_FAST_ALLOCATED). I'd prefer to keep them stack-allocated for now.
If not, we should make sure the allocator churn is not hurting perf (we're
allocating/deallocating a paint server every time we paint an object now).

[fs, 2014/10/10 16:10:23]

Aha! Reviewer inconsistency detected - parity error. Scrub attempted.

I suppose I can appease you both with something like:

class SVGPaintServer {
  ...
  bool operator!() const { return !(m_color.rgba() || m_gradient || m_pattern);
}
};

(works assuming no "weird" blend-modes - which I think can be assumed ATM.)

I'll upload that shortly, but I'd be nice to get a uniform reviewer opinion
here.

[fs, 2014/10/10 16:44:41]

Can be found in PS7+ - I went with an explicit isValid instead of operator.
Could also just use a "bool m_isValid" if preferable.

+    if (!paintServer)
+        return false;
+    paintServer->apply(*context, resourceMode, &stateSaver);
+
+    const SVGRenderStyle& svgStyle = style->svgStyle();
+
+    if (resourceMode == ApplyToFillMode) {
+        context->setAlphaAsFloat(svgStyle.fillOpacity());
+        context->setFillRule(svgStyle.fillRule());
+    } else {
+        context->setAlphaAsFloat(svgStyle.strokeOpacity());
+        SVGRenderSupport::applyStrokeStyleToContext(context, style, &renderer);
+    }
+    return true;
+}
+
+} // namespace blink