Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: docs/quickstart.md

Issue 638913005: Remove references to out/Debug/tests executable. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/quickstart.md
diff --git a/docs/quickstart.md b/docs/quickstart.md
index 9a7b01cb5e2905b49d11da6f1761dca1df12140b..6c779a7d38ab761269ed200e2a1747089bf151ed 100644
--- a/docs/quickstart.md
+++ b/docs/quickstart.md
@@ -26,18 +26,17 @@ This guide assumes you've got `git`, `ninja`, and `python` on your path.
* `ninja -C out/Release`: optimization, asserts disabled
* `ninja -C out/Coverage`: no optimization, asserts enabled, code coverage generated
5. Run some tests:
- * `out/Debug/tests`: runs unit tests from tests/
- * `out/Debug/dm`: runs golden master tests from gm/
+ * `out/Debug/dm`: runs golden master tests from gm/, unit tests from tests/
6. Make some changes:
* `git checkout -b my-new-feature origin/master`
* `vim src/...`
* `git commit -am "Changes for my new feature."`
* `vim tests/...`
* `git commit --amend -a`
- * `ninja -C out/Debug && out/Debug/tests && out/Debug/dm && echo ok`
+ * `ninja -C out/Debug && out/Debug/dm && echo ok`
7. Rebase your change onto the latest Skia code:
* `git pull --rebase`
- * `ninja -C out/Debug && out/Debug/tests && out/Debug/dm && echo ok`
+ * `ninja -C out/Debug && out/Debug/dm && echo ok`
8. Upload your change and send it out for review:
* `git cl upload -r my-skia-reviewer@google.com -s`
* `git cl web`
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698