Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 638863002: Replace FINAL and OVERRIDE with their C++11 counterparts in chrome/utility (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in chrome/utility This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/8200a5e46ced911517722f6ffc79a411c8ef254f Cr-Commit-Position: refs/heads/master@{#298788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -56 lines) Patch
M chrome/utility/chrome_content_utility_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/image_writer/image_writer_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/image_writer/image_writer_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/importer/bookmark_html_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/bookmarks_file_importer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/external_process_importer_bridge.h View 1 chunk +14 lines, -14 lines 0 comments Download
M chrome/utility/importer/firefox_importer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils_mac.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/safari_importer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/local_discovery/service_discovery_message_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/local_discovery/service_discovery_message_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/media_galleries/ipc_data_source.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/utility/media_galleries/iphoto_library_parser.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/utility/media_galleries/itunes_library_parser.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/media_galleries/picasa_albums_indexer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/printing_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/printing_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/profile_import_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/shell_handler_win.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-08 12:19:57 UTC) #2
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-08 18:44:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638863002/1
6 years, 2 months ago (2014-10-08 18:48:06 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
6 years, 2 months ago (2014-10-08 20:10:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638863002/1
6 years, 2 months ago (2014-10-08 20:13:36 UTC) #9
commit-bot: I haz the power
Failed to apply the patch.
6 years, 2 months ago (2014-10-08 20:18:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638863002/1
6 years, 2 months ago (2014-10-09 00:49:44 UTC) #13
MRV
On 2014/10/08 18:44:47, Lei Zhang wrote: > lgtm Thanks mr. Lei zhang for review.
6 years, 2 months ago (2014-10-09 00:52:33 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4ab120cf3ec536a5c3eeb02c1a5f663cc46fcc01
6 years, 2 months ago (2014-10-09 04:50:30 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 04:51:23 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8200a5e46ced911517722f6ffc79a411c8ef254f
Cr-Commit-Position: refs/heads/master@{#298788}

Powered by Google App Engine
This is Rietveld 408576698