Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 638853004: [turbofan] Eliminate typed array bounds checks if both key and length are constant. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Eliminate typed array bounds checks if both key and length are constant. TEST=mjsunit,unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -1 line) Patch
M src/compiler/node-matchers.h View 1 chunk +35 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 2 chunks +36 lines, -0 lines 0 comments Download
A test/mjsunit/asm/int32array-constant-key.js View 1 chunk +32 lines, -0 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 2 chunks +59 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-17 09:03:38 UTC) #1
dcarney
lgtm
6 years, 2 months ago (2014-10-17 09:16:53 UTC) #2
Benedikt Meurer
6 years, 2 months ago (2014-10-17 09:36:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24685 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698