Reorganizes Chromecast code to better reflect functional dependencies.

chromecast/chromecast.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
     'chromecast_branding%': 'Chromium',
   },
   'target_defaults': {
@@ skipping 91 matching lines @@
       'target_name': 'cast_net',
       'type': '<(component)',
       'sources': [
         'net/network_change_notifier_cast.cc',
         'net/network_change_notifier_cast.h',
         'net/network_change_notifier_factory_cast.cc',
         'net/network_change_notifier_factory_cast.h',
       ],
     },
     {
-      'target_name': 'cast_service',
-      'type': '<(component)',
-      'dependencies': [
-        '../skia/skia.gyp:skia',
-      ],
-      'sources': [
-        'service/cast_service.cc',
-        'service/cast_service.h',
-      ],
-      'conditions': [
-        ['chromecast_branding=="Chrome"', {
-          'dependencies': [
-            'internal/chromecast_internal.gyp:cast_service_internal',
-          ],
-        }, {
-          'dependencies': [
-            '../base/base.gyp:base',
-            '../content/content.gyp:content',
-          ],
-          'conditions': [
-            ['OS=="android"', {
-              'sources': [
-                'service/cast_service_android.cc',
-                'service/cast_service_android.h',
-              ],
-            }, {
-              'sources': [
-                'service/cast_service_simple.cc',
-                'service/cast_service_simple.h',
-              ],
-            }],
-          ],
-        }],
-      ],
-    },
-    {
       'target_name': 'cast_shell_resources',
       'type': 'none',
       'variables': {
         'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/chromecast',
       },
       'actions': [
         {
           'action_name': 'cast_shell_resources',
           'variables': {
-            'grit_grd_file': 'shell/browser/resources/shell_resources.grd',
-            'grit_resource_ids': 'shell/browser/resources/resource_ids',
+            'grit_grd_file': 'app/resources/shell_resources.grd',
+            'grit_resource_ids': 'app/resources/resource_ids',
           },
           'includes': [ '../build/grit_action.gypi' ],
         },
       ],
       'includes': [ '../build/grit_target.gypi' ],
     },
     {
       'target_name': 'cast_shell_pak',
       'type': 'none',
       'dependencies': [
@@ skipping 30 matching lines @@
       ],
     },
     # This target contains all content-embedder implementation that is
     # non-platform-specific.
     {
       'target_name': 'cast_shell_common',
       'type': '<(component)',
       'dependencies': [
         'cast_common',
         'cast_metrics',
-        'cast_service',
         'cast_shell_pak',
         'cast_shell_resources',
         'cast_version_header',
         'chromecast_locales.gyp:chromecast_locales_pak',
         'chromecast_locales.gyp:chromecast_settings',
         'media/media.gyp:media_base',
+        '../base/base.gyp:base',
         '../components/components.gyp:cdm_renderer',
         '../components/components.gyp:component_metrics_proto',
         '../content/content.gyp:content',
         '../content/content.gyp:content_app_browser',
         '../skia/skia.gyp:skia',
         '../third_party/WebKit/public/blink.gyp:blink',
         '../third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h',
       ],
       'sources': [
-        'shell/app/cast_main_delegate.cc',
-        'shell/app/cast_main_delegate.h',
-        'shell/browser/cast_browser_context.cc',
-        'shell/browser/cast_browser_context.h',
-        'shell/browser/cast_browser_main_parts.cc',
-        'shell/browser/cast_browser_main_parts.h',
-        'shell/browser/cast_browser_process.cc',
-        'shell/browser/cast_browser_process.h',
-        'shell/browser/cast_content_browser_client.cc',
-        'shell/browser/cast_content_browser_client.h',
-        'shell/browser/cast_download_manager_delegate.cc',
-        'shell/browser/cast_download_manager_delegate.h',
-        'shell/browser/cast_http_user_agent_settings.cc',
-        'shell/browser/cast_http_user_agent_settings.h',
-        'shell/browser/cast_network_delegate.cc',
-        'shell/browser/cast_network_delegate.h',
-        'shell/browser/devtools/cast_dev_tools_delegate.cc',
-        'shell/browser/devtools/cast_dev_tools_delegate.h',
-        'shell/browser/devtools/remote_debugging_server.cc',
-        'shell/browser/devtools/remote_debugging_server.h',
-        'shell/browser/geolocation/cast_access_token_store.cc',
-        'shell/browser/geolocation/cast_access_token_store.h',
-        'shell/browser/url_request_context_factory.cc',
-        'shell/browser/url_request_context_factory.h',
-        'shell/browser/webui/webui_cast.h',
-        'shell/common/cast_content_client.cc',
-        'shell/common/cast_content_client.h',
-        'shell/renderer/cast_content_renderer_client.cc',
-        'shell/renderer/cast_content_renderer_client.h',
-        'shell/renderer/key_systems_cast.cc',
-        'shell/renderer/key_systems_cast.h',
+        'app/cast_content_client.cc',
+        'app/cast_content_client.h',

[lcwu1, 2014/10/13 01:26:35]

Why do you want to place cast_content_client.[cc|h] in app/ instead of in
common/ like what chrome and content_shell do?

[gunsch, 2014/10/13 03:13:17]

That was a very conscious decision:
* chromecast/common does not currently have any dependency on content/ and I'd
like to keep it that way
* conceptually, CastContentClient seems to me to fit with the other code in
app/, such as CastMainDelegate, under the notion of "content/ implementation
that's neither browser- or renderer-specific."

+        'app/cast_main_delegate.cc',
+        'app/cast_main_delegate.h',
+        'browser/cast_browser_context.cc',
+        'browser/cast_browser_context.h',
+        'browser/cast_browser_main_parts.cc',
+        'browser/cast_browser_main_parts.h',
+        'browser/cast_browser_process.cc',
+        'browser/cast_browser_process.h',
+        'browser/cast_content_browser_client.cc',
+        'browser/cast_content_browser_client.h',
+        'browser/cast_download_manager_delegate.cc',
+        'browser/cast_download_manager_delegate.h',
+        'browser/cast_http_user_agent_settings.cc',
+        'browser/cast_http_user_agent_settings.h',
+        'browser/cast_network_delegate.cc',
+        'browser/cast_network_delegate.h',
+        'browser/devtools/cast_dev_tools_delegate.cc',
+        'browser/devtools/cast_dev_tools_delegate.h',
+        'browser/devtools/remote_debugging_server.cc',
+        'browser/devtools/remote_debugging_server.h',
+        'browser/geolocation/cast_access_token_store.cc',
+        'browser/geolocation/cast_access_token_store.h',
+        'browser/service/cast_service.cc',
+        'browser/service/cast_service.h',
+        'browser/url_request_context_factory.cc',
+        'browser/url_request_context_factory.h',
+        'browser/webui/webui_cast.h',
+        'renderer/cast_content_renderer_client.cc',
+        'renderer/cast_content_renderer_client.h',
+        'renderer/key_systems_cast.cc',
+        'renderer/key_systems_cast.h',
       ],
       'conditions': [
         ['chromecast_branding=="Chrome"', {
           'dependencies': [
             'internal/chromecast_internal.gyp:cast_shell_internal',
           ],
         }, {
           'sources': [
-            'shell/browser/cast_network_delegate_simple.cc',
-            'shell/browser/devtools/remote_debugging_server_simple.cc',
-            'shell/browser/webui/webui_cast_simple.cc',
-            'shell/renderer/key_systems_cast_simple.cc',
+            'browser/cast_network_delegate_simple.cc',
+            'browser/devtools/remote_debugging_server_simple.cc',
+            'browser/webui/webui_cast_simple.cc',
+            'renderer/key_systems_cast_simple.cc',
+          ],
+          'conditions': [
+            ['OS=="android"', {
+              'sources': [
+                'browser/service/cast_service_android.cc',
+                'browser/service/cast_service_android.h',
+              ],
+            }, {
+              'sources': [
+                'browser/service/cast_service_simple.cc',
+                'browser/service/cast_service_simple.h',
+              ],
+            }],
           ],
         }],
       ],
     },
     {
       'target_name': 'cast_version_header',
       'type': 'none',
       'direct_dependent_settings': {
         'include_dirs': [
           '<(SHARED_INTERMEDIATE_DIR)',
@@ skipping 60 matching lines @@
           ],
           'include_dirs': [
             '../breakpad/src',
           ],
           'sources': [
             'android/cast_jni_registrar.cc',
             'android/cast_jni_registrar.h',
             'android/chromecast_config_android.cc',
             'android/chromecast_config_android.h',
             'android/platform_jni_loader.h',
+            'app/android/cast_jni_loader.cc',
+            'browser/android/cast_window_android.cc',
+            'browser/android/cast_window_android.h',
+            'browser/android/cast_window_manager.cc',
+            'browser/android/cast_window_manager.h',
+            'browser/android/external_video_surface_container_impl.cc',
+            'browser/android/external_video_surface_container_impl.h',
             'crash/android/cast_crash_reporter_client_android.cc',
             'crash/android/cast_crash_reporter_client_android.h',
             'crash/android/crash_handler.cc',
             'crash/android/crash_handler.h',
-            'shell/app/android/cast_jni_loader.cc',
-            'shell/browser/android/cast_window_android.cc',
-            'shell/browser/android/cast_window_android.h',
-            'shell/browser/android/cast_window_manager.cc',
-            'shell/browser/android/cast_window_manager.h',
-            'shell/browser/android/external_video_surface_container_impl.cc',
-            'shell/browser/android/external_video_surface_container_impl.h',
           ],
           'conditions': [
             ['chromecast_branding=="Chrome"', {
               'dependencies': [
                 '<(cast_internal_gyp):cast_shell_android_internal'
               ],
             }, {
               'sources': [
                 'android/chromecast_config_android_stub.cc',
                 'android/platform_jni_loader_stub.cc',
               ],
             }]
           ],
         },  # end of target 'libcast_shell_android'
         {
           'target_name': 'cast_shell_java',
           'type': 'none',
           'dependencies': [
             '../base/base.gyp:base_java',
             '../content/content.gyp:content_java',
             '../media/media.gyp:media_java',
             '../net/net.gyp:net_java',
             '../third_party/android_tools/android_tools.gyp:android_support_v13_javalib',
             '../ui/android/ui_android.gyp:ui_java',
           ],
           'variables': {
             'has_java_resources': 1,
-            'java_in_dir': 'shell/android/apk',
-            'resource_dir': 'shell/android/apk/res',
+            'java_in_dir': 'browser/android/apk',
+            'resource_dir': 'browser/android/apk/res',
             'R_package': 'org.chromium.chromecast.shell',
           },
           'includes': ['../build/java.gypi'],
         },  # end of target 'cast_shell_java'
         {
           'target_name': 'cast_shell_apk',
           'type': 'none',
           'dependencies': [
             'cast_shell_java',
             'libcast_shell_android',
           ],
           'variables': {
             'apk_name': 'CastShell',
             'manifest_package_name': 'org.chromium.chromecast.shell',
             # Note(gunsch): there are no Java files in the android/ directory.
             # Unfortunately, the java_apk.gypi target rigidly insists on having
             # a java_in_dir directory, but complains about duplicate classes
             # from the common cast_shell_java target (shared with internal APK)
             # if the actual Java path is used.
             # This will hopefully be removable after the great GN migration.
             'java_in_dir': 'android',
-            'android_manifest_path': 'shell/android/apk/AndroidManifest.xml',
+            'android_manifest_path': 'browser/android/apk/AndroidManifest.xml',
             'package_name': 'org.chromium.chromecast.shell',
             'native_lib_target': 'libcast_shell_android',
             'asset_location': '<(PRODUCT_DIR)/assets',
             'additional_input_paths': ['<(PRODUCT_DIR)/assets/cast_shell.pak'],
           },
           'includes': [ '../build/java_apk.gypi' ],
         },
         {
           'target_name': 'cast_jni_headers',
           'type': 'none',
           'sources': [
-            'shell/android/apk/src/org/chromium/chromecast/shell/CastCrashHandler.java',
-            'shell/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java',
-            'shell/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java',
-            'shell/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java',
+            'browser/android/apk/src/org/chromium/chromecast/shell/CastCrashHandler.java',
+            'browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java',
+            'browser/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java',
+            'browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java',
           ],
           'direct_dependent_settings': {
             'include_dirs': [
               '<(SHARED_INTERMEDIATE_DIR)/chromecast',
             ],
           },
           'variables': {
             'jni_gen_package': 'chromecast',
           },
           'includes': [ '../build/jni_generator.gypi' ],
@@ skipping 25 matching lines @@
             }],
           ],
         },
         {
           'target_name': 'cast_shell',
           'type': 'executable',
           'dependencies': [
             'cast_shell_core',
           ],
           'sources': [
-            'shell/app/cast_main.cc',
+            'app/cast_main.cc',
           ],
         },
         {
           'target_name': 'cast_shell_browser_test',
           'type': '<(gtest_target_type)',
           'dependencies': [
             'cast_shell_test_support',
             '../testing/gtest.gyp:gtest',
           ],
           'defines': [
             'HAS_OUT_OF_PROC_TEST_RUNNER',
           ],
           'sources': [
-            'shell/browser/test/chromecast_shell_browser_test.cc',
+            'browser/test/chromecast_shell_browser_test.cc',
           ],
         },
         {
           'target_name': 'cast_shell_test_support',
           'type': '<(component)',
           'defines': [
             'HAS_OUT_OF_PROC_TEST_RUNNER',
           ],
           'dependencies': [
             'cast_shell_core',
             '../content/content_shell_and_tests.gyp:content_browser_test_support',
             '../testing/gtest.gyp:gtest',
           ],
           'sources': [
-            'shell/browser/test/chromecast_browser_test.cc',
-            'shell/browser/test/chromecast_browser_test.h',
-            'shell/browser/test/chromecast_browser_test_runner.cc',
+            'browser/test/chromecast_browser_test.cc',
+            'browser/test/chromecast_browser_test.h',
+            'browser/test/chromecast_browser_test_runner.cc',
           ],
         },
       ],  # end of targets
     }],
   ],  # end of conditions
 }