base: Fix gn check errors on base/allocator.

base: Fix gn check errors on base/allocator.

Fix a bunch of errors like:

ERROR at //third_party/tcmalloc/chromium/src/base/abort.cc:7:11: Include
not allowed.
          ^----------------
          It is not in any dependency of //base/allocator:tcmalloc
The include file is in the target(s): //base:base
which should somehow be reachable from //base/allocator:tcmalloc

After this, //base/* is `gn check` clean.

BUG=None
TEST=out/Debug/gn check out_gn/Debug //base/*
R=brettw@chromium.org

[tfarina, 2014-10-08 02:09:42]

Is this fine? ptal.

[brettw, 2014-10-08 04:51:13]

I guess so. lgtm but I'm not a base owner any more.

[jamesr, 2014-10-08 20:07:42]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2014-10-08 20:07:42]

This doesn't look right - I think the header checker is getting confused about
the relative include paths used by third_party/tcmalloc/chromium/src/base or
we're setting the wrong include paths.  That code is not intended to use the
basictypes.h from chromium's base/ directory

[tfarina, 2014-10-09 02:22:25]

On 2014/10/08 20:07:42, jamesr wrote:
> This doesn't look right - I think the header checker is getting confused about
> the relative include paths used by third_party/tcmalloc/chromium/src/base or
> we're setting the wrong include paths.  That code is not intended to use the
> basictypes.h from chromium's base/ directory

[tfarina, 2014-10-09 02:27:19]

On 2014/10/09 02:22:25, tfarina wrote:
> On 2014/10/08 20:07:42, jamesr wrote:
> > This doesn't look right - I think the header checker is getting confused
about
> > the relative include paths used by third_party/tcmalloc/chromium/src/base or
> > we're setting the wrong include paths.  That code is not intended to use the
> > basictypes.h from chromium's base/ directory

Yeah, I have to agree with that. I don't like the solution either, hence I
didn't did it together with the other gn check patch I did for patch.

So, we have third_party/tcmalloc/chromium/src, but that is built by
base/allocator? Do you know the motivation?

I think I won't land this ;)

Would be feasible/possible to change tcmalloc includes to
third_party/tcmalloc/chromium/src/base/basictypes.h, for example?