Issue 638723002: Add GetModifiedFiles() function to git_utils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 638723002: Add GetModifiedFiles() function to git_utils. (Closed)

Created:
6 years, 2 months ago by tfarina

Modified:
6 years, 2 months ago

Reviewers:
borenet

CC:
reviews_skia.org, rmistry

Base URL:
https://skia.googlesource.com/common@master

Project:
skiacommon

Visibility:
Public.

Add GetModifiedFiles() function to git_utils. It will be used in a follow up CL to replace _GitGetModifiedFiles() from tools/svndiff.py in skia.googlesource.com/skia repo. BUG=None TEST=./py/run_unittests R=borenet@google.com Committed: https://skia.googlesource.com/common/+/af1de867422c42855ae54ed3838c62ea445ea6b4

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	py/utils/git_utils.py	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

borenet

On 2014/10/07 20:32:37, tfarina wrote: > Is this OK? Yep. LGTM

6 years, 2 months ago (2014-10-08 12:42:19 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638723002/1

6 years, 2 months ago (2014-10-08 16:02:27 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-08 16:02:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as af1de867422c42855ae54ed3838c62ea445ea6b4