Issue 638703004: Fix mime-handler-view crash upon creation:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 638703004: Fix mime-handler-view crash upon creation: (Closed)

Created:
6 years, 2 months ago by lazyboy

Modified:
6 years, 2 months ago

Reviewers:
Fady Samuel

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix mime-handler-view crash upon creation: We don't do create/attach steps through JavaScript API. This broke after https://crrev.com/e7c9f7781cbc6db099dacbefdc19ac2fd9bfc19a landed. BUG=303491 Test=Open chrome with --out-of-process-pdf and --enable-mime-handler-view, Navigate to a PDF, renderer process shouldn't crash. Committed: https://crrev.com/b3e7acfa2273ba3c88b988db4e85beb1014ea35f Cr-Commit-Position: refs/heads/master@{#298572}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	extensions/renderer/guest_view/guest_view_container.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638703004/1

6 years, 2 months ago (2014-10-07 20:00:55 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 6a1a666b61e1df65f467c9a527f9ca506389e83e

6 years, 2 months ago (2014-10-07 21:11:59 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-10-07 21:12:32 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b3e7acfa2273ba3c88b988db4e85beb1014ea35f
Cr-Commit-Position: refs/heads/master@{#298572}