Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 638663002: Write out unique includes in element factories (Closed)

Created:
6 years, 2 months ago by rwlbuis
Modified:
6 years, 2 months ago
Reviewers:
adamk
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Write out unique includes in element factories Modify the writing out of element includes so that only unique includes are made. This mainly improves HTMLElementFactory.cpp where HTMLElement.h was included 44 times. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/build/scripts/templates/ElementFactory.cpp.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL, just a small cleanup.
6 years, 2 months ago (2014-10-07 21:03:58 UTC) #2
adamk
lgtm
6 years, 2 months ago (2014-10-07 21:05:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638663002/1
6 years, 2 months ago (2014-10-07 21:11:41 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 00:02:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183368

Powered by Google App Engine
This is Rietveld 408576698