Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: ui/compositor/compositor.h

Issue 638653003: Make ui::Compositor use ui::Scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase with enable mode patch since that would probably go in before this Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/compositor/compositor.h
diff --git a/ui/compositor/compositor.h b/ui/compositor/compositor.h
index 57e4a8e28067ecb3804b06a5e30dcd765c73bea9..bf61d29730e67aa70bd7c8533baa860a2335de42 100644
--- a/ui/compositor/compositor.h
+++ b/ui/compositor/compositor.h
@@ -25,8 +25,6 @@
#include "ui/gfx/size.h"
#include "ui/gfx/vector2d.h"
-class SkBitmap;
-
namespace base {
class MessageLoopProxy;
class RunLoop;
@@ -175,9 +173,6 @@ class COMPOSITOR_EXPORT Compositor
// compositing layers on.
float device_scale_factor() const { return device_scale_factor_; }
- // Draws the scene created by the layer tree and any visual effects.
- void Draw();
-
// Where possible, draws are scissored to a damage region calculated from
// changes to layer properties. This bypasses that and indicates that
// the whole frame needs to be drawn.
@@ -264,14 +259,9 @@ class COMPOSITOR_EXPORT Compositor
void DidCompleteSwapBuffers() override;
// cc::LayerTreeHostSingleThreadClient implementation.
- void ScheduleComposite() override;
- void ScheduleAnimation() override;
void DidPostSwapBuffers() override;
void DidAbortSwapBuffers() override;
- int last_started_frame() { return last_started_frame_; }
- int last_ended_frame() { return last_ended_frame_; }
-
bool IsLocked() { return compositor_lock_ != NULL; }
const cc::LayerTreeDebugState& GetLayerTreeDebugState() const;
@@ -296,9 +286,6 @@ class COMPOSITOR_EXPORT Compositor
// Called to release any pending CompositorLock
void CancelCompositorLock();
- // Notifies the compositor that compositing is complete.
- void NotifyEnd();
-
gfx::Size size_;
ui::ContextFactory* context_factory_;
@@ -330,15 +317,6 @@ class COMPOSITOR_EXPORT Compositor
CompositorLock* compositor_lock_;
- // Prevent more than one draw from being scheduled.
- bool defer_draw_scheduling_;
-
- // Used to prevent Draw()s while a composite is in progress.
- bool waiting_on_compositing_end_;
- bool draw_on_compositing_end_;
- enum SwapState { SWAP_NONE, SWAP_POSTED, SWAP_COMPLETED };
- SwapState swap_state_;
-
LayerAnimatorCollection layer_animator_collection_;
base::WeakPtrFactory<Compositor> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698