Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: cc/trees/single_thread_proxy.cc

Issue 638653003: Make ui::Compositor use ui::Scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase with enable mode patch since that would probably go in before this Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/single_thread_proxy.cc
diff --git a/cc/trees/single_thread_proxy.cc b/cc/trees/single_thread_proxy.cc
index dfce8088d18ac248bfef847f62a4ac35231bc3ac..56d244c41301e10ff3c18394a554b065c8519501 100644
--- a/cc/trees/single_thread_proxy.cc
+++ b/cc/trees/single_thread_proxy.cc
@@ -90,6 +90,7 @@ void SingleThreadProxy::SetLayerTreeHostClientReady() {
if (layer_tree_host_->settings().single_thread_proxy_scheduler &&
!scheduler_on_impl_thread_) {
SchedulerSettings scheduler_settings(layer_tree_host_->settings());
+ // SingleThreadProxy should run in main thread low latency mode.
scheduler_settings.main_thread_should_always_be_low_latency = true;
scheduler_on_impl_thread_ =
Scheduler::Create(this,
@@ -426,13 +427,10 @@ void SingleThreadProxy::DidActivateSyncTree() {
// the pending tree is not actually ready in the SingleThreadProxy.
layer_tree_host_impl_->SetRequiresHighResToDraw();
- // Since activation could cause tasks to run, post CommitComplete
- // separately so that it runs after these tasks. This is the loose
- // equivalent of blocking commit until activation and also running
- // all tasks posted during commit/activation before CommitComplete.
- MainThreadTaskRunner()->PostTask(
- FROM_HERE, base::Bind(&SingleThreadProxy::CommitComplete,
- weak_factory_.GetWeakPtr()));
+ // Synchronously call to CommitComplete. Resetting
+ // |commit_blocking_task_runner| would make sure all tasks posted during
+ // commit/activation before CommitComplete.
+ CommitComplete();
}
timing_history_.DidActivateSyncTree();

Powered by Google App Engine
This is Rietveld 408576698