test/cctest/test-log-stack-tracer.cc - Issue 638633002: Tick processor: Print C++ entry points

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-log-stack-tracer.cc

Issue 638633002: Tick processor: Print C++ entry points (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-log-stack-tracer.cc

diff --git a/test/cctest/test-log-stack-tracer.cc b/test/cctest/test-log-stack-tracer.cc

index 334a2010532bd3373b7547ede2ff4142ea7988e7..33e9dc14d84212aec89ddbae89a4aa1789fa4ae7 100644

--- a/test/cctest/test-log-stack-tracer.cc

+++ b/test/cctest/test-log-stack-tracer.cc

@@ -172,7 +172,7 @@ TEST(CFromJSStackTrace) {

CHECK_EQ(FUNCTION_ADDR(i::TraceExtension::Trace), sample.external_callback);

// Stack tracing will start from the first JS function, i.e. "JSFuncDoTrace"

- unsigned base = 0;

+ unsigned base = 1;

CHECK_GT(sample.frames_count, base + 1);

CHECK(IsAddressWithinFuncCode(