Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: src/runtime/runtime-classes.cc

Issue 638623002: Keyed stores to super where key is a name. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Stray edit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdlib.h> 5 #include <stdlib.h>
6 #include <limits> 6 #include <limits>
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 Object::SUPER_PROPERTY)); 127 Object::SUPER_PROPERTY));
128 return *result; 128 return *result;
129 } 129 }
130 130
131 131
132 RUNTIME_FUNCTION(Runtime_StoreToSuper_Strict) { 132 RUNTIME_FUNCTION(Runtime_StoreToSuper_Strict) {
133 HandleScope scope(isolate); 133 HandleScope scope(isolate);
134 DCHECK(args.length() == 4); 134 DCHECK(args.length() == 4);
135 CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 0); 135 CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 0);
136 CONVERT_ARG_HANDLE_CHECKED(JSObject, home_object, 1); 136 CONVERT_ARG_HANDLE_CHECKED(JSObject, home_object, 1);
137 CONVERT_ARG_HANDLE_CHECKED(Object, value, 2); 137 CONVERT_ARG_HANDLE_CHECKED(Name, name, 2);
138 CONVERT_ARG_HANDLE_CHECKED(Name, name, 3); 138 CONVERT_ARG_HANDLE_CHECKED(Object, value, 3);
139 139
140 return StoreToSuper(isolate, home_object, receiver, name, value, STRICT); 140 return StoreToSuper(isolate, home_object, receiver, name, value, STRICT);
141 } 141 }
142 142
143 143
144 RUNTIME_FUNCTION(Runtime_StoreToSuper_Sloppy) { 144 RUNTIME_FUNCTION(Runtime_StoreToSuper_Sloppy) {
145 HandleScope scope(isolate); 145 HandleScope scope(isolate);
146 DCHECK(args.length() == 4); 146 DCHECK(args.length() == 4);
147 CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 0); 147 CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 0);
148 CONVERT_ARG_HANDLE_CHECKED(JSObject, home_object, 1); 148 CONVERT_ARG_HANDLE_CHECKED(JSObject, home_object, 1);
149 CONVERT_ARG_HANDLE_CHECKED(Object, value, 2); 149 CONVERT_ARG_HANDLE_CHECKED(Name, name, 2);
150 CONVERT_ARG_HANDLE_CHECKED(Name, name, 3); 150 CONVERT_ARG_HANDLE_CHECKED(Object, value, 3);
151 151
152 return StoreToSuper(isolate, home_object, receiver, name, value, SLOPPY); 152 return StoreToSuper(isolate, home_object, receiver, name, value, SLOPPY);
153 } 153 }
154
155
156 static Object* StoreKeyedToSuper(Isolate* isolate, Handle<JSObject> home_object,
157 Handle<Object> receiver, Handle<Object> key,
158 Handle<Object> value, StrictMode strict_mode) {
159 Handle<Name> name;
160 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, name,
161 Runtime::ToName(isolate, key));
162 uint32_t index;
163 if (name->AsArrayIndex(&index)) {
164 return ThrowUnsupportedSuper(isolate);
arv (Not doing code reviews) 2014/10/07 15:05:38 // TODO(dslomov): Implement
Dmitry Lomov (no reviews) 2014/10/07 15:53:37 Done.
165 }
166 return StoreToSuper(isolate, home_object, receiver, name, value, strict_mode);
167 }
168
169
170 RUNTIME_FUNCTION(Runtime_StoreKeyedToSuper_Strict) {
171 HandleScope scope(isolate);
172 DCHECK(args.length() == 4);
173 CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 0);
174 CONVERT_ARG_HANDLE_CHECKED(JSObject, home_object, 1);
175 CONVERT_ARG_HANDLE_CHECKED(Object, key, 2);
176 CONVERT_ARG_HANDLE_CHECKED(Object, value, 3);
177
178 return StoreKeyedToSuper(isolate, home_object, receiver, key, value, STRICT);
179 }
180
181
182 RUNTIME_FUNCTION(Runtime_StoreKeyedToSuper_Sloppy) {
183 HandleScope scope(isolate);
184 DCHECK(args.length() == 4);
185 CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 0);
186 CONVERT_ARG_HANDLE_CHECKED(JSObject, home_object, 1);
187 CONVERT_ARG_HANDLE_CHECKED(Object, key, 2);
188 CONVERT_ARG_HANDLE_CHECKED(Object, value, 3);
189
190 return StoreKeyedToSuper(isolate, home_object, receiver, key, value, SLOPPY);
191 }
154 } 192 }
155 } // namespace v8::internal 193 } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698