Issue 638553003: Move fdlibm in src/third_party.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 638553003: Move fdlibm in src/third_party. (Closed)

Created:
6 years, 2 months ago by ulan

Modified:
6 years, 2 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1154 lines)			Patch
M	BUILD.gn	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/runtime/runtime-maths.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	src/third_party/fdlibm/LICENSE	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/third_party/fdlibm/README.v8	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/third_party/fdlibm/fdlibm.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/third_party/fdlibm/fdlibm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	src/third_party/fdlibm/fdlibm.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	third_party/fdlibm/LICENSE	View		1 chunk	+0 lines, -6 lines	0 comments	Download
D	third_party/fdlibm/README.v8	View		1 chunk	+0 lines, -18 lines	0 comments	Download
D	third_party/fdlibm/fdlibm.h	View		1 chunk	+0 lines, -31 lines	0 comments	Download
D	third_party/fdlibm/fdlibm.cc	View		1 chunk	+0 lines, -281 lines	0 comments	Download
D	third_party/fdlibm/fdlibm.js	View		1 chunk	+0 lines, -814 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Yang

On 2014/10/07 09:51:10, ulan wrote: > PTAL LGTM. Diff line count in Rietveld is weird: ...

6 years, 2 months ago (2014-10-07 09:53:58 UTC) #3

ulan

6 years, 2 months ago (2014-10-08 11:20:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24464 (presubmit successful).