Issue 638533002: Fix bugs in lowering NumberToInt32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 638533002: Fix bugs in lowering NumberToInt32. (Closed)

Created:
6 years, 2 months ago by titzer

Modified:
6 years, 2 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Fix bugs in lowering NumberToInt32. The backward propagation was different in the lowering phase versus the propagation phase, leading to some missing truncations. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24434

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -31 lines)			Patch
	M	src/compiler/simplified-lowering.cc	View		1 chunk	+25 lines, -31 lines	0 comments	Download
	M	test/cctest/compiler/test-simplified-lowering.cc	View	1	7 chunks	+81 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

titzer

6 years, 2 months ago (2014-10-07 12:18:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 24434 (presubmit successful).