Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 638533002: Fix bugs in lowering NumberToInt32. (Closed)

Created:
6 years, 2 months ago by titzer
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix bugs in lowering NumberToInt32. The backward propagation was different in the lowering phase versus the propagation phase, leading to some missing truncations. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24434

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -31 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +25 lines, -31 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 7 chunks +81 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 2 months ago (2014-10-07 09:03:57 UTC) #1
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-07 09:05:05 UTC) #2
titzer
6 years, 2 months ago (2014-10-07 12:18:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 24434 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698