Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 638503003: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/loader (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/loader This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183334

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -270 lines) Patch
M Source/core/loader/BeaconLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/loader/DocumentThreadableLoader.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/loader/DocumentThreadableLoaderClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/EmptyClients.h View 3 chunks +154 lines, -154 lines 0 comments Download
M Source/core/loader/EmptyClients.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/loader/FormState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameFetchContext.h View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/ImageLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/LinkLoader.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/loader/MixedContentChecker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/NavigationScheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/NavigationScheduler.cpp View 8 chunks +13 lines, -13 lines 0 comments Download
M Source/core/loader/PingLoader.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/loader/PrerenderHandle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/ProgressTracker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/SinkDocument.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/SinkDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/TextTrackLoader.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/loader/WorkerLoaderClientBridge.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/loader/WorkerLoaderClientBridgeSyncHelper.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/loader/WorkerThreadableLoader.h View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCache.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCacheHost.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 11:52:29 UTC) #2
Mike West
LGTM.
6 years, 2 months ago (2014-10-07 12:53:32 UTC) #5
MRV
On 2014/10/07 12:53:32, Mike West wrote: > LGTM. Thanks Mr. Mike
6 years, 2 months ago (2014-10-07 12:54:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638503003/1
6 years, 2 months ago (2014-10-07 12:56:45 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 14:07:06 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183334

Powered by Google App Engine
This is Rietveld 408576698