Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 638503002: Replacing the OVERRIDE with override and FINAL with final in content/browser/[download|… (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in content/browser/geolocation/[download|loader|quota] This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/0673e938d521ab5cfe49536dc1109a7210f954fb Cr-Commit-Position: refs/heads/master@{#298496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -408 lines) Patch
M content/browser/download/download_browsertest.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M content/browser/download/download_file_impl.h View 1 chunk +11 lines, -11 lines 0 comments Download
M content/browser/download/download_file_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/download_item_impl.h View 2 chunks +70 lines, -70 lines 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/download/download_manager_impl.h View 3 chunks +26 lines, -26 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/download/download_request_handle.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/download/download_resource_handler.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/download/drag_download_file.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/download/drag_download_file.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/drag_download_file_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/drag_download_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/file_metadata_unittest_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/mhtml_generation_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/save_file_resource_handler.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/download/save_package.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/save_package.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/download/save_package_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/async_resource_handler.h View 1 chunk +10 lines, -10 lines 0 comments Download
M content/browser/loader/buffered_resource_handler.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/loader/certificate_resource_handler.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/loader/cross_site_resource_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/loader/detachable_resource_handler.h View 1 chunk +14 lines, -14 lines 0 comments Download
M content/browser/loader/layered_resource_handler.h View 1 chunk +10 lines, -10 lines 0 comments Download
M content/browser/loader/power_save_block_resource_throttle.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 3 chunks +12 lines, -12 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 16 chunks +19 lines, -19 lines 0 comments Download
M content/browser/loader/resource_loader.h View 1 chunk +13 lines, -13 lines 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 10 chunks +20 lines, -20 lines 0 comments Download
M content/browser/loader/resource_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.h View 1 chunk +19 lines, -19 lines 0 comments Download
M content/browser/loader/resource_scheduler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/loader/resource_scheduler_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/loader/stream_resource_handler.h View 1 chunk +11 lines, -11 lines 0 comments Download
M content/browser/loader/sync_resource_handler.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/loader/throttling_resource_handler.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/quota/mock_quota_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/quota/mock_quota_manager_proxy.h View 3 chunks +7 lines, -7 lines 0 comments Download
M content/browser/quota/quota_backend_impl_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/quota/quota_reservation_manager_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M content/browser/quota/quota_temporary_storage_evictor_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/quota/storage_monitor_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M content/browser/quota/usage_tracker_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 07:00:35 UTC) #2
Avi (use Gerrit)
Stampity stamp LGTM
6 years, 2 months ago (2014-10-07 14:26:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638503002/1
6 years, 2 months ago (2014-10-07 14:56:31 UTC) #5
MRV
On 2014/10/07 14:26:13, Avi wrote: > Stampity stamp LGTM Thanks mr. Avi.
6 years, 2 months ago (2014-10-07 15:00:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1ce81fb4c35afe89773fde2bc909d61d174132cf
6 years, 2 months ago (2014-10-07 16:18:02 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 16:18:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0673e938d521ab5cfe49536dc1109a7210f954fb
Cr-Commit-Position: refs/heads/master@{#298496}

Powered by Google App Engine
This is Rietveld 408576698