Issue 638433003: Adding a reason field to expectAsync and expectAsyncUntil

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 638433003: Adding a reason field to expectAsync and expectAsyncUntil (Closed)

Created:
6 years, 2 months ago by srawlins

Modified:
6 years, 2 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -8 lines)			Patch
M	pkg/unittest/CHANGELOG.md	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/unittest/lib/src/spread_args_helper.dart	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	pkg/unittest/lib/unittest.dart	View		2 chunks	+13 lines, -4 lines	0 comments	Download
M	pkg/unittest/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

srawlins

Hi Bob, adding reason: to expectAsync and expectAsyncUntil. There aren't any tests because the other ...

6 years, 2 months ago (2014-10-07 06:13:26 UTC) #2

Bob Nystrom

Oh, don't forget to bump the version in the pubspec too.

6 years, 2 months ago (2014-10-07 17:59:00 UTC) #4

srawlins

On 2014/10/07 17:59:00, Bob Nystrom wrote: > Oh, don't forget to bump the version in ...

6 years, 2 months ago (2014-10-07 18:44:23 UTC) #5

srawlins

6 years, 2 months ago (2014-10-07 18:47:20 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 40967 (presubmit successful).