Issue 63843003: Mojo: Add support for attributes [name=value] on interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63843003: Mojo: Add support for attributes [name=value] on interfaces. (Closed)

Created:
7 years, 1 month ago by darin (slow to review)

Modified:
7 years, 1 month ago

Reviewers:
DaveMoore

CC:
chromium-reviews, Aaron Boodman, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Add support for attributes [name=value] on interfaces. This will be useful for defining peer relations between interfaces. R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233652

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	mojo/public/bindings/parser/mojo_parser.py	View		2 chunks	+4 lines, -3 lines	1 comment	Download
	M	mojo/public/bindings/parser/mojo_translate.py	View		2 chunks	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

https://codereview.chromium.org/63843003/diff/1/mojo/public/bindings/parser/mojo_parser.py File mojo/public/bindings/parser/mojo_parser.py (right): https://codereview.chromium.org/63843003/diff/1/mojo/public/bindings/parser/mojo_parser.py#newcode153 mojo/public/bindings/parser/mojo_parser.py:153: """attribute : NAME EQUALS NUMBER Previously, I had just ...

7 years, 1 month ago (2013-11-07 06:14:30 UTC) #1

darin (slow to review)

7 years, 1 month ago (2013-11-07 19:09:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r233652 (presubmit successful).

Expand Messages | Collapse Messages