Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: content/child/indexed_db/indexed_db_message_filter.cc

Issue 63843002: Add ChildMessageFilter, a base class for renderer/worker cross-thread MessageFilter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: RemoveFilter fix Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/indexed_db/indexed_db_message_filter.h ('k') | content/child/quota_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/indexed_db/indexed_db_message_filter.cc
diff --git a/content/child/indexed_db/indexed_db_message_filter.cc b/content/child/indexed_db/indexed_db_message_filter.cc
index 7022925e6d0569898bc5a13fe3a13c72456b90ce..6d2305fb4091f6bbf7971e88519f974a3fd82b48 100644
--- a/content/child/indexed_db/indexed_db_message_filter.cc
+++ b/content/child/indexed_db/indexed_db_message_filter.cc
@@ -4,16 +4,11 @@
#include "content/child/indexed_db/indexed_db_message_filter.h"
-#include "base/bind.h"
-#include "base/location.h"
#include "base/message_loop/message_loop_proxy.h"
-#include "base/pickle.h"
#include "content/child/indexed_db/indexed_db_dispatcher.h"
#include "content/child/thread_safe_sender.h"
+#include "content/child/worker_thread_task_runner.h"
#include "content/common/indexed_db/indexed_db_messages.h"
-#include "webkit/child/worker_task_runner.h"
-
-using webkit_glue::WorkerTaskRunner;
namespace content {
@@ -23,31 +18,26 @@ IndexedDBMessageFilter::IndexedDBMessageFilter(
thread_safe_sender_(thread_safe_sender) {
}
-bool IndexedDBMessageFilter::OnMessageReceived(const IPC::Message& msg) {
- if (IPC_MESSAGE_CLASS(msg) != IndexedDBMsgStart)
- return false;
- int ipc_thread_id = -1;
- bool result = PickleIterator(msg).ReadInt(&ipc_thread_id);
- DCHECK(result);
- base::Closure closure = base::Bind(
- &IndexedDBMessageFilter::DispatchMessage, this, msg);
- if (!ipc_thread_id) {
- main_thread_loop_proxy_->PostTask(FROM_HERE, closure);
- return true;
- }
- if (WorkerTaskRunner::Instance()->PostTask(ipc_thread_id, closure))
- return true;
+IndexedDBMessageFilter::~IndexedDBMessageFilter() {}
- // Message for a terminated worker - perform necessary cleanup
- OnStaleMessageReceived(msg);
- return true;
+base::TaskRunner* IndexedDBMessageFilter::OverrideTaskRunnerForMessage(
+ const IPC::Message& msg) {
+ if (IPC_MESSAGE_CLASS(msg) != IndexedDBMsgStart)
+ return NULL;
+ int ipc_thread_id = 0;
+ const bool success = PickleIterator(msg).ReadInt(&ipc_thread_id);
+ DCHECK(success);
+ if (!ipc_thread_id)
+ return main_thread_loop_proxy_.get();
+ return new WorkerThreadTaskRunner(ipc_thread_id);
}
-IndexedDBMessageFilter::~IndexedDBMessageFilter() {}
-
-void IndexedDBMessageFilter::DispatchMessage(const IPC::Message& msg) {
+bool IndexedDBMessageFilter::OnMessageReceived(const IPC::Message& msg) {
+ if (IPC_MESSAGE_CLASS(msg) != IndexedDBMsgStart)
+ return false;
IndexedDBDispatcher::ThreadSpecificInstance(thread_safe_sender_.get())
->OnMessageReceived(msg);
+ return true;
}
void IndexedDBMessageFilter::OnStaleMessageReceived(const IPC::Message& msg) {
« no previous file with comments | « content/child/indexed_db/indexed_db_message_filter.h ('k') | content/child/quota_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698