Add ChildMessageFilter, a base class for renderer/worker cross-thread MessageFilter

content/child/child_message_filter.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_CHILD_CROSS_MESSAGE_FILTER_H_
+#define CONTENT_CHILD_CROSS_MESSAGE_FILTER_H_
+
+#include "ipc/ipc_channel_proxy.h"
+
+namespace base {
+class TaskRunner;
+}
+
+namespace content {
+
+class ThreadSafeSender;
+
+// A base class for implementing IPC MessageFilter's that run on a different
+// thread or TaskRunner than the main thread.
+class ChildMessageFilter
+    : public base::RefCountedThreadSafe<ChildMessageFilter>,
+      public IPC::Sender {
+ public:
+  // IPC::Sender implementation. Can be called on any threads.
+  virtual bool Send(IPC::Message* message) OVERRIDE;
+
+  // If implementors want to run OnMessageReceived on a different task

[jam, 2013/11/18 05:50:02]

nit: implementers

[kinuko, 2013/11/18 06:35:46]

Done.

+  // runner it should override this and return the TaskRunner for the message.
+  // Returning NULL by default, which runs OnMessageReceived() on the
+  // current IPC thread.
+  virtual base::TaskRunner* OverrideTaskRunnerForMessage(
+      const IPC::Message& msg);

[jam, 2013/11/18 05:50:02]

nit: seems that this should be pure virtual as that's the whole reason for using
this class?

[kinuko, 2013/11/18 06:35:46]

Yup... done.

+
+  // If OverrideTaskRunnerForMessage is overriden and returns non-null
+  // this will be called on the returned TaskRunner.
+  virtual bool OnMessageReceived(const IPC::Message& msg) = 0;
+
+  // This method is called when WorkerTaskRunner::PostTask() returned false
+  // for the target thread.  Note that there's still a listtle chance that

[jam, 2013/11/18 05:50:02]

nit: little chance

[kinuko, 2013/11/18 06:35:46]

Done.

+  // PostTask() returns true but OnMessageReceivedOnTargetThread() is
+  // never called.  By default this does nothing.
+  virtual void OnStaleMessageReceived(const IPC::Message& msg) {}
+
+ protected:
+  ChildMessageFilter();
+  virtual ~ChildMessageFilter();
+
+ private:
+  class Internal;
+  friend class ChildThread;
+  friend class RenderThreadImpl;
+  friend class WorkerThread;
+
+  friend class base::RefCountedThreadSafe<ChildMessageFilter>;
+
+  IPC::ChannelProxy::MessageFilter* GetFilter();
+
+  // This implements IPC::ChannelProxy::MessageFilter to hide the actual
+  // filter methods from child classes.
+  Internal* internal_;
+
+  scoped_refptr<ThreadSafeSender> thread_safe_sender_;
+
+  DISALLOW_COPY_AND_ASSIGN(ChildMessageFilter);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_CHILD_CROSS_MESSAGE_FILTER_H_