Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 638423002: Massively speed up aspect ratio-detecting WebRTC tests. (Closed)

Created:
6 years, 2 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
Reviewers:
perkj_chrome, mcasas
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Massively speed up aspect ratio-detecting WebRTC tests. This improves the execution speed by a factor 3x, and I think they're just as correct. Essentially we are waiting until we see a good aspect ratio, rather than the old behavior which was to wait 10x50 ms and see if we have a good aspect ratio. This wasn't a problem on fast machines, but it's a big problem on bots with GPU emulation where canvas operations are expensive. BUG=417756 R=perkj@chromium.org,mcasas@chromium.org Committed: https://crrev.com/d877c645673dfb198eef231f719395d5f7d6c634 Cr-Commit-Position: refs/heads/master@{#299073}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Now clearing on failure. #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M content/test/data/media/getusermedia.html View 1 2 2 chunks +20 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
phoglund_chromium
6 years, 2 months ago (2014-10-09 14:21:26 UTC) #1
perkj_chrome
lgtm if the below is addressed. https://codereview.chromium.org/638423002/diff/1/content/test/data/media/getusermedia.html File content/test/data/media/getusermedia.html (left): https://codereview.chromium.org/638423002/diff/1/content/test/data/media/getusermedia.html#oldcode435 content/test/data/media/getusermedia.html:435: clearInterval(detectorInterval); I think ...
6 years, 2 months ago (2014-10-09 14:43:22 UTC) #2
phoglund_chromium
https://codereview.chromium.org/638423002/diff/1/content/test/data/media/getusermedia.html File content/test/data/media/getusermedia.html (left): https://codereview.chromium.org/638423002/diff/1/content/test/data/media/getusermedia.html#oldcode435 content/test/data/media/getusermedia.html:435: clearInterval(detectorInterval); On 2014/10/09 14:43:22, perkj wrote: > I think ...
6 years, 2 months ago (2014-10-09 15:04:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638423002/40001
6 years, 2 months ago (2014-10-10 06:35:48 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-10 07:36:50 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 07:37:35 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d877c645673dfb198eef231f719395d5f7d6c634
Cr-Commit-Position: refs/heads/master@{#299073}

Powered by Google App Engine
This is Rietveld 408576698