Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 638413002: [media] Apply automatic range checks to content enum types across IPC (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
chromium-reviews, mkwst+moarreviews-ipc_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, MRV
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[media] Apply automatic range checks to content enum types across IPC This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://crrev.com/9f6fde290ca5a86291bdf9e89bd7388fa0bb7487 Cr-Commit-Position: refs/heads/master@{#298897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/common/media/media_player_messages_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/media/media_player_messages_enums_android.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-09 14:04:23 UTC) #2
Mike West
lgtm These are great, keep them coming. :)
6 years, 2 months ago (2014-10-09 14:05:24 UTC) #4
anujsharma
On 2014/10/09 14:05:24, Mike West wrote: > lgtm > > These are great, keep them ...
6 years, 2 months ago (2014-10-09 14:05:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638413002/1
6 years, 2 months ago (2014-10-09 14:06:39 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
6 years, 2 months ago (2014-10-09 15:16:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638413002/1
6 years, 2 months ago (2014-10-09 16:21:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as c88facbf379fa681c099b0aaf294dd3638fe3be0
6 years, 2 months ago (2014-10-09 16:23:22 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 16:24:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f6fde290ca5a86291bdf9e89bd7388fa0bb7487
Cr-Commit-Position: refs/heads/master@{#298897}

Powered by Google App Engine
This is Rietveld 408576698