Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 638383002: Disable edit and print button when there is no selection. (Closed)

Created:
6 years, 2 months ago by yawano
Modified:
6 years, 2 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable edit and print button when there is no selection. BUG=421767 TEST=Open Gallery.app; In slide mode, delete all images by clicking bottom-right delete button. Committed: https://crrev.com/5938395e0b1ff3ce9b540fa1efeded2d554d0052 Cr-Commit-Position: refs/heads/master@{#299057}

Patch Set 1 #

Patch Set 2 : Moved the disable/enable logic. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M ui/file_manager/gallery/js/slide_mode.js View 1 6 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL.
6 years, 2 months ago (2014-10-09 10:47:26 UTC) #2
yawano
Added a patch set. PTAL. Thanks.
6 years, 2 months ago (2014-10-10 00:42:42 UTC) #3
hirono
Thank you, LGTM!
6 years, 2 months ago (2014-10-10 02:28:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638383002/20001
6 years, 2 months ago (2014-10-10 03:50:25 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-10 04:31:39 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 04:32:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5938395e0b1ff3ce9b540fa1efeded2d554d0052
Cr-Commit-Position: refs/heads/master@{#299057}

Powered by Google App Engine
This is Rietveld 408576698