Issue 638373003: webtry: Do not forget the close the rows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 638373003: webtry: Do not forget the close the rows. (Closed)

Created:
6 years, 2 months ago by tfarina

Modified:
6 years, 2 months ago

Reviewers:
humper

CC:
reviews_skia.org, jcgregorio, stephana

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

webtry: Do not forget the close the rows. This should prevent further enumeration according to the docs. http://golang.org/pkg/database/sql/#Rows.Close BUG=None TEST=None R=humper@google.com Committed: https://skia.googlesource.com/skia/+/8c0d2aab621445ce84aa77ee5425680aa899a459

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	experimental/webtry/webtry.go	View		4 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638373003/1

6 years, 2 months ago (2014-10-16 12:52:07 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-16 12:57:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 8c0d2aab621445ce84aa77ee5425680aa899a459